> On May 19, 2015, 10 p.m., Hari Sankar Sivarama Subramaniyan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java, > > line 1610 > > <https://reviews.apache.org/r/34385/diff/2/?file=964375#file964375line1610> > > > > I see that these jiras have been committed and better to remove these > > comments.
These comments were part of those commits. They are there because currently vectorization is off for them, but in future it can be enabled once the underlying problems (as noted there) are resolved. This patch is not fixing those problems, so it makes sense to leave them there. - Ashutosh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34385/#review84391 ----------------------------------------------------------- On May 19, 2015, 9:14 p.m., Ashutosh Chauhan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34385/ > ----------------------------------------------------------- > > (Updated May 19, 2015, 9:14 p.m.) > > > Review request for hive and Gopal V. > > > Bugs: HIVE-10745 > https://issues.apache.org/jira/browse/HIVE-10745 > > > Repository: hive-git > > > Description > ------- > > Better null handling by Vectorizer > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeEvaluatorFactory.java > f08321c > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java > 48f34a9 > > Diff: https://reviews.apache.org/r/34385/diff/ > > > Testing > ------- > > > Thanks, > > Ashutosh Chauhan > >
