----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35792/#review89285 -----------------------------------------------------------
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (line 2202) <https://reviews.apache.org/r/35792/#comment141873> 1. Remove leading spaces or tabs. 2. The default should be "false" conf/hive-site.xml (line 22) <https://reviews.apache.org/r/35792/#comment141875> We probably don't want to add anything here, as these properties have default values which are sufficient. service/src/java/org/apache/hive/service/cli/ColumnCompressor.java (line 15) <https://reviews.apache.org/r/35792/#comment141880> Documentation for these public APIs? service/src/java/org/apache/hive/service/cli/ColumnCompressorService.java (line 11) <https://reviews.apache.org/r/35792/#comment141878> 1. Why hashtable? We should use HashMap or ConcurrentHashMap rather than HashTable. 2. <> will break people building Hive with Java 6. service/src/java/org/apache/hive/service/cli/ColumnCompressorService.java (line 19) <https://reviews.apache.org/r/35792/#comment141876> Remove trailing spaces. Same for other occurrences. First round of review comments. Most cosmatic. More will come. - Xuefu Zhang On June 23, 2015, 8:39 p.m., Rohit Dholakia wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35792/ > ----------------------------------------------------------- > > (Updated June 23, 2015, 8:39 p.m.) > > > Review request for hive, Vaibhav Gumashta and Xuefu Zhang. > > > Repository: hive-git > > > Description > ------- > > This patch enables ResultSet compression for Hive using external plugins. The > patch proposes a plugin architecture that enables using external plugins to > compress ResultSets on-the-fly. > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 27f68df > conf/hive-site.xml dab494e > service/if/TCLIService.thrift baf583f > service/src/gen/thrift/gen-cpp/TCLIService_types.h 7bceabd > service/src/gen/thrift/gen-cpp/TCLIService_types.cpp 86eeea3 > > service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TEnColumn.java > PRE-CREATION > > service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TExecuteStatementReq.java > 4f157ad > > service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TGetTablesReq.java > c973fcc > > service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TOpenSessionReq.java > c048161 > > service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TOpenSessionResp.java > 351f78b > > service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TProtocolVersion.java > a4279d2 > > service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TRowSet.java > d16c8a4 > > service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TStatus.java > 24a746e > service/src/gen/thrift/gen-py/TCLIService/ttypes.py 068727c > service/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb b482533 > service/src/java/org/apache/hive/service/cli/Column.java 2e21f18 > service/src/java/org/apache/hive/service/cli/ColumnBasedSet.java 47a582e > service/src/java/org/apache/hive/service/cli/ColumnCompressor.java > PRE-CREATION > service/src/java/org/apache/hive/service/cli/ColumnCompressorService.java > PRE-CREATION > service/src/java/org/apache/hive/service/cli/EncodedColumnBasedSet.java > PRE-CREATION > service/src/java/org/apache/hive/service/cli/RowSetFactory.java e8f68ea > service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java > dfb7faa > > Diff: https://reviews.apache.org/r/35792/diff/ > > > Testing > ------- > > Testing has been done using a docker container-based query submitter that has > an integer decompressor as part of it. Using the integer compressor (also > provided) and the decompressor, the end-to-end functionality can be observed. > > > File Attachments > ---------------- > > Patch file > > https://reviews.apache.org/media/uploaded/files/2015/06/23/16aa08f8-2393-460a-83ef-72464fc537db__HIVE-10438.patch > > > Thanks, > > Rohit Dholakia > >
