----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35792/#review94821 -----------------------------------------------------------
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (line 2201) <https://reviews.apache.org/r/35792/#comment149462> For HiveServer2 specific configs, we use the format hive.server2.* service/src/java/org/apache/hive/service/cli/RowSetFactory.java (line 31) <https://reviews.apache.org/r/35792/#comment149459> What happens to versions > V9? service/src/java/org/apache/hive/service/cli/compression/ColumnCompressorService.java (line 76) <https://reviews.apache.org/r/35792/#comment149562> We should log the cause on catching this exception. service/src/java/org/apache/hive/service/cli/compression/EncodedColumnBasedSet.java (line 46) <https://reviews.apache.org/r/35792/#comment149563> How would the client send this string? Will it be a new API call from the driver code? Can you elaborate a bit more? service/src/java/org/apache/hive/service/cli/compression/EncodedColumnBasedSet.java (line 59) <https://reviews.apache.org/r/35792/#comment149465> Nit: whitespace. service/src/java/org/apache/hive/service/cli/compression/EncodedColumnBasedSet.java (line 96) <https://reviews.apache.org/r/35792/#comment149564> How is CompressorInfo being set? service/src/java/org/apache/hive/service/cli/compression/EncodedColumnBasedSet.java (line 97) <https://reviews.apache.org/r/35792/#comment149466> Nit: whitespace. service/src/test/org/apache/hive/service/cli/compression/SnappyIntCompressor.java (line 64) <https://reviews.apache.org/r/35792/#comment149533> Nit: whitespace. service/src/test/org/apache/hive/service/cli/compression/TestEncodedColumnBasedSet.java (line 56) <https://reviews.apache.org/r/35792/#comment149534> Nit: whitespace. - Vaibhav Gumashta On June 29, 2015, 5:41 p.m., Rohit Dholakia wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35792/ > ----------------------------------------------------------- > > (Updated June 29, 2015, 5:41 p.m.) > > > Review request for hive, Vaibhav Gumashta, Xiaojian Wang, Xiao Meng, and > Xuefu Zhang. > > > Repository: hive-git > > > Description > ------- > > This patch enables ResultSet compression for Hive using external plugins. The > patch proposes a plugin architecture that enables using external plugins to > compress ResultSets on-the-fly. > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 27f68df > service/if/TCLIService.thrift baf583f > service/src/gen/thrift/gen-cpp/TCLIService_types.h 7bceabd > service/src/gen/thrift/gen-cpp/TCLIService_types.cpp 86eeea3 > > service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TEnColumn.java > PRE-CREATION > > service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TExecuteStatementReq.java > 4f157ad > > service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TGetTablesReq.java > c973fcc > > service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TOpenSessionReq.java > c048161 > > service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TOpenSessionResp.java > 351f78b > > service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TProtocolVersion.java > a4279d2 > > service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TRowSet.java > d16c8a4 > > service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TStatus.java > 24a746e > service/src/gen/thrift/gen-py/TCLIService/ttypes.py 068727c > service/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb b482533 > service/src/java/org/apache/hive/service/cli/Column.java 2e21f18 > service/src/java/org/apache/hive/service/cli/ColumnBasedSet.java 47a582e > service/src/java/org/apache/hive/service/cli/RowSetFactory.java e8f68ea > > service/src/java/org/apache/hive/service/cli/compression/ColumnCompressor.java > PRE-CREATION > > service/src/java/org/apache/hive/service/cli/compression/ColumnCompressorService.java > PRE-CREATION > > service/src/java/org/apache/hive/service/cli/compression/EncodedColumnBasedSet.java > PRE-CREATION > service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java > dfb7faa > > service/src/main/resources/META-INF/services/org.apache.hive.service.cli.compression.ColumnCompressor > PRE-CREATION > > service/src/test/org/apache/hive/service/cli/compression/SnappyIntCompressor.java > PRE-CREATION > > service/src/test/org/apache/hive/service/cli/compression/TestEncodedColumnBasedSet.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/35792/diff/ > > > Testing > ------- > > Testing has been done using a docker container-based query submitter that has > an integer decompressor as part of it. Using the integer compressor (also > provided) and the decompressor, the end-to-end functionality can be observed. > > > File Attachments > ---------------- > > Patch file > > https://reviews.apache.org/media/uploaded/files/2015/06/23/16aa08f8-2393-460a-83ef-72464fc537db__HIVE-10438.patch > > > Thanks, > > Rohit Dholakia > >
