----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36284/#review90886 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinToMultiJoinRule.java (line 185) <https://reviews.apache.org/r/36284/#comment144052> Should we add a message here (DEBUG or WARN level) with the Exception, to know exactly what was going on? - Jesús Camacho Rodríguez On July 7, 2015, 11:09 p.m., Ashutosh Chauhan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36284/ > ----------------------------------------------------------- > > (Updated July 7, 2015, 11:09 p.m.) > > > Review request for hive and Jesús Camacho Rodríguez. > > > Bugs: HIVE-11197 > https://issues.apache.org/jira/browse/HIVE-11197 > > > Repository: hive-git > > > Description > ------- > > While extracting join conditions follow Hive rules for type conversion > instead of Calcite > > > Diffs > ----- > > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveCalciteUtil.java > 024097e > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRelOptUtil.java > 9ebb24f > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinToMultiJoinRule.java > c5e0e11 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdSelectivity.java > 960ec40 > > Diff: https://reviews.apache.org/r/36284/diff/ > > > Testing > ------- > > Existing tests. > > > Thanks, > > Ashutosh Chauhan > >
