----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36506/#review91837 -----------------------------------------------------------
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java (line 1866) <https://reviews.apache.org/r/36506/#comment145479> why removing duplicates here? maybe add some comments? metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java (line 1869) <https://reviews.apache.org/r/36506/#comment145478> lowerTableNames doesn't really make sense. Maybe lowercaseTableNames? metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java (line 1880) <https://reviews.apache.org/r/36506/#comment145477> why here tableNames.size() is used? would there be any issue? - Chao Sun On July 15, 2015, 1:30 p.m., Aihua Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36506/ > ----------------------------------------------------------- > > (Updated July 15, 2015, 1:30 p.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > HIVE-11255 get_table_objects_by_name() in HiveMetaStore.java needs to > retrieve table objects in multiple batches > > > Diffs > ----- > > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java > dffeb34f443048b8fc4b39d1e5089e82ea3ffac4 > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 2ef5aa0706f7043639fcac38d058bec4289ee9a1 > > Diff: https://reviews.apache.org/r/36506/diff/ > > > Testing > ------- > > > Thanks, > > Aihua Xu > >
