> On July 15, 2015, 11:02 p.m., Chao Sun wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java, > > line 1866 > > <https://reviews.apache.org/r/36506/diff/1/?file=1012747#file1012747line1866> > > > > why removing duplicates here? maybe add some comments?
Since we can provide a list with duplicate tables like "Table1, table1, TABLE1" and we still need to return only one table1 object. Before JDO call can handle that automatically. Now since we could split into multiple lists, we need to remove duplicates before hand. I will add comments. - Aihua ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36506/#review91837 ----------------------------------------------------------- On July 15, 2015, 1:30 p.m., Aihua Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36506/ > ----------------------------------------------------------- > > (Updated July 15, 2015, 1:30 p.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > HIVE-11255 get_table_objects_by_name() in HiveMetaStore.java needs to > retrieve table objects in multiple batches > > > Diffs > ----- > > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java > dffeb34f443048b8fc4b39d1e5089e82ea3ffac4 > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 2ef5aa0706f7043639fcac38d058bec4289ee9a1 > > Diff: https://reviews.apache.org/r/36506/diff/ > > > Testing > ------- > > > Thanks, > > Aihua Xu > >
