----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36962/#review94382 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/exec/Operator.java <https://reviews.apache.org/r/36962/#comment148960> I wouldn't remove this method; although it is not used right now, it is generic enough to be used in the future. ql/src/java/org/apache/hadoop/hive/ql/optimizer/GroupByOptimizer.java (line 573) <https://reviews.apache.org/r/36962/#comment148959> The mismatch that can exist is only due to different column names, am I right? Then could we add an assert here: parent.getSchema().getSignature().size() == curr.getSchema().getSignature().size() ? - Jesús Camacho Rodríguez On Aug. 3, 2015, 11:30 p.m., pengcheng xiong wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36962/ > ----------------------------------------------------------- > > (Updated Aug. 3, 2015, 11:30 p.m.) > > > Review request for hive and Jesús Camacho Rodríguez. > > > Repository: hive-git > > > Description > ------- > > solution is to add a SEL in between > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/Operator.java 0f02737 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/GroupByOptimizer.java > af54286 > > Diff: https://reviews.apache.org/r/36962/diff/ > > > Testing > ------- > > > Thanks, > > pengcheng xiong > >
