> On Sept. 16, 2015, 10:37 p.m., Hari Sankar Sivarama Subramaniyan wrote: > > ql/src/test/results/clientpositive/pointlookup4.q.out, line 377 > > <https://reviews.apache.org/r/38123/diff/1/?file=1063891#file1063891line377> > > > > As noticed before, it looks like partition condition remover doesnt > > kick in and removes the partition only columns from the predicate.
Once HIVE-11634 goes in, this should be solved, right? > On Sept. 16, 2015, 10:37 p.m., Hari Sankar Sivarama Subramaniyan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/PointLookupOptimizer.java, > > line 440 > > <https://reviews.apache.org/r/38123/diff/1/?file=1063887#file1063887line440> > > > > Looked at the entire code, seems like the change is similar to > > HIVE-11634. Can you please verify with the change in HIVE-11634. Yes, you are right. I added a comment in HIVE-11634, it seems we will only keep the logic to push the predicate to the metastore in this patch. - Jesús ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38123/#review99321 ----------------------------------------------------------- On Sept. 4, 2015, 5:49 a.m., Jesús Camacho Rodríguez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38123/ > ----------------------------------------------------------- > > (Updated Sept. 4, 2015, 5:49 a.m.) > > > Review request for hive, Ashutosh Chauhan, Hari Sankar Sivarama Subramaniyan, > and John Pullokkaran. > > > Bugs: HIVE-11726 > https://issues.apache.org/jira/browse/HIVE-11726 > > > Repository: hive-git > > > Description > ------- > > HIVE-11726 > > > Diffs > ----- > > metastore/src/java/org/apache/hadoop/hive/metastore/parser/Filter.g > 8aef5bf631361cf4f30f532b9a5fb5e376c06de8 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/PointLookupOptimizer.java > d83636db82ecc1cb891df92736f284b1b29f29c0 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/OpProcFactory.java > 7262164d39547b7832f52873a48ee998219230b1 > ql/src/java/org/apache/hadoop/hive/ql/plan/FilterDesc.java > 6a316895aacdd5d26d866c2b0c72ef4407e591e1 > ql/src/test/queries/clientpositive/pointlookup4.q PRE-CREATION > ql/src/test/results/clientpositive/pointlookup4.q.out PRE-CREATION > > Diff: https://reviews.apache.org/r/38123/diff/ > > > Testing > ------- > > Existing tests (pointlookup1-4.q) > > > Thanks, > > Jesús Camacho Rodríguez > >
