----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38211/#review100456 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSortJoinReduceRule.java (line 172) <https://reviews.apache.org/r/38211/#comment157655> We should seperate Limit push through Project from Limit Push through Join. Looking for Limit/Proj/Join is a hard coupling. - John Pullokkaran On Sept. 17, 2015, 1:55 p.m., Jesús Camacho Rodríguez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38211/ > ----------------------------------------------------------- > > (Updated Sept. 17, 2015, 1:55 p.m.) > > > Review request for hive and John Pullokkaran. > > > Bugs: HIVE-11684 > https://issues.apache.org/jira/browse/HIVE-11684 > > > Repository: hive-git > > > Description > ------- > > Implement limit pushdown through outer join in CBO > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > 7f29da29f861c0e6c11065a95092d9e7e7b08aba > itests/src/test/resources/testconfiguration.properties > 0d3e1cc17df496e8b4dd8c3622017cd15384348a > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSortJoinReduceRule.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java > 0a7ce3a5f81f3175cddc59319753be3bb0b2af04 > ql/src/test/queries/clientpositive/limit_join_transpose.q PRE-CREATION > ql/src/test/queries/clientpositive/tez_dynpart_hashjoin_3.q PRE-CREATION > ql/src/test/results/clientpositive/limit_join_transpose.q.out PRE-CREATION > ql/src/test/results/clientpositive/tez/tez_dynpart_hashjoin_3.q.out > PRE-CREATION > > Diff: https://reviews.apache.org/r/38211/diff/ > > > Testing > ------- > > Two new tests added: limit_join_transpose.q and tez_dynpart_hashjoin_3.q > (only Tez) > > > Thanks, > > Jesús Camacho Rodríguez > >