----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38211/#review101851 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSortJoinReduceRule.java (line 80) <https://reviews.apache.org/r/38211/#comment159364> "reduction" as it is set is not a %. Shouldn't you multiply by ((100-reduction)/100) guarding for reduction to be <= 100. - John Pullokkaran On Sept. 28, 2015, 11:40 a.m., Jesús Camacho Rodríguez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38211/ > ----------------------------------------------------------- > > (Updated Sept. 28, 2015, 11:40 a.m.) > > > Review request for hive and John Pullokkaran. > > > Bugs: HIVE-11684 > https://issues.apache.org/jira/browse/HIVE-11684 > > > Repository: hive-git > > > Description > ------- > > Implement limit pushdown through outer join in CBO > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > dffdb5c14114d9c2d1e4c44a36f6b60966dcfc86 > itests/src/test/resources/testconfiguration.properties > 4f7b25f2563683933b9d677626f0447705927966 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSortJoinReduceRule.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSortProjectTransposeRule.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java > 9c731b8c5e58570570812b525b8bf0edb0f4c0a9 > ql/src/test/queries/clientpositive/limit_join_transpose.q PRE-CREATION > ql/src/test/queries/clientpositive/tez_dynpart_hashjoin_3.q PRE-CREATION > ql/src/test/results/clientpositive/limit_join_transpose.q.out PRE-CREATION > ql/src/test/results/clientpositive/tez/tez_dynpart_hashjoin_3.q.out > PRE-CREATION > > Diff: https://reviews.apache.org/r/38211/diff/ > > > Testing > ------- > > Two new tests added: limit_join_transpose.q and tez_dynpart_hashjoin_3.q > (only Tez) > > > Thanks, > > Jesús Camacho Rodríguez > >
