> On 10 13, 2015, 9:35 오후, Thejas Nair wrote: > > ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java, line 309 > > <https://reviews.apache.org/r/38292/diff/2/?file=1096900#file1096900line309> > > > > I think this method could be re-used in other parts of hive as well. > > How about adding this a FileUtils.deleteTmpFile and a new > > FileUtils.createTmpFile method ? > > Can you also add a unit test for those methods ?
Sure > On 10 13, 2015, 9:35 오후, Thejas Nair wrote: > > ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java, line 871 > > <https://reviews.apache.org/r/38292/diff/2/?file=1096900#file1096900line871> > > > > same as above comment . A method in FileUtils for use throughout hive > > would be useful. Consider it done - Navis ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38292/#review102537 ----------------------------------------------------------- On 10 13, 2015, 1:19 오전, Navis Ryu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38292/ > ----------------------------------------------------------- > > (Updated 10 13, 2015, 1:19 오전) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > More than 490,000 paths was added to java.io.DeleteOnExitHook on one of our > long running HiveServer2 instances,taken up more than 100MB on heap. > Most of the paths contains a suffix of ".pipeout". > > > Diffs > ----- > > common/src/java/org/apache/hive/common/util/ShutdownHookManager.java > fd2f20a > ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 41b4bb1 > > service/src/java/org/apache/hive/service/cli/operation/HiveCommandOperation.java > 1d1e995 > service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java > 175348b > > Diff: https://reviews.apache.org/r/38292/diff/ > > > Testing > ------- > > > Thanks, > > Navis Ryu > >
