----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38292/#review102728 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java (line 302) <https://reviews.apache.org/r/38292/#comment160469> the comment is no longer applicable ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java (line 307) <https://reviews.apache.org/r/38292/#comment160470> the comment is no longer applicable here common/src/java/org/apache/hadoop/hive/common/FileUtils.java (line 776) <https://reviews.apache.org/r/38292/#comment160471> Can you also please add javadoc to this method saying that it registers for deletion on exit with shutdown hook. Also that deleteTmpFile method should be called for temp files created using this to free up the memory. Can you also please add a unit test case ? It can check if the shutdown hook entry is getting freed on the deletion. - Thejas Nair On Oct. 14, 2015, 12:49 a.m., Navis Ryu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38292/ > ----------------------------------------------------------- > > (Updated Oct. 14, 2015, 12:49 a.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > More than 490,000 paths was added to java.io.DeleteOnExitHook on one of our > long running HiveServer2 instances,taken up more than 100MB on heap. > Most of the paths contains a suffix of ".pipeout". > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/common/FileUtils.java 7e4f386 > common/src/java/org/apache/hive/common/util/ShutdownHookManager.java > fd2f20a > common/src/test/org/apache/hive/common/util/TestShutdownHookManager.java > fa30f15 > ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 41b4bb1 > > service/src/java/org/apache/hive/service/cli/operation/HiveCommandOperation.java > 1d1e995 > service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java > 175348b > > Diff: https://reviews.apache.org/r/38292/diff/ > > > Testing > ------- > > > Thanks, > > Navis Ryu > >
