> On Nov. 30, 2015, 2:16 a.m., Jesús Camacho Rodríguez wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/HiveGBOpConvUtil.java, > > line 1020 > > <https://reviews.apache.org/r/40101/diff/2/?file=1121009#file1121009line1020> > > > > Lines 1019-1026. > > > > We store the position of the argument for the function in the input > > (_argPos_). But then the logic is difficult to follow. > > _distinctPositions_ stores _argPos_, but _argPos_ is not used to obtain > > _rsUDAFParamColInfo_ from _rsColInfoLst_ in the _else_ block. Why? Does the > > code make the assumption that we visit the distinct positions in order i.e. > > pos 3 should always have been visited before 4? > > Thus, in the _else_ block, _gbInfo.gbKeys.size() + > > distinctPositions.size()_ = _argPos_, right? Then the _rsColInfoLst.get_ > > call could be taken out of the block. > > Jesús Camacho Rodríguez wrote: > Got it, distinct and value positions can be mixed.
Maybe we could add a comment about it? - Jesús ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40101/#review105902 ----------------------------------------------------------- On Nov. 10, 2015, 12:58 a.m., pengcheng xiong wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40101/ > ----------------------------------------------------------- > > (Updated Nov. 10, 2015, 12:58 a.m.) > > > Review request for hive and Jesús Camacho Rodríguez. > > > Repository: hive-git > > > Description > ------- > > The position in argList is mapped to a wrong column from RS operator > > > Diffs > ----- > > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/HiveGBOpConvUtil.java > a129cf3 > ql/src/test/queries/clientpositive/cbo_rp_groupby3_noskew_multi_distinct.q > PRE-CREATION > ql/src/test/queries/clientpositive/cbo_rp_udf_percentile.q PRE-CREATION > ql/src/test/queries/clientpositive/cbo_rp_udf_percentile2.q PRE-CREATION > > ql/src/test/results/clientpositive/cbo_rp_groupby3_noskew_multi_distinct.q.out > PRE-CREATION > ql/src/test/results/clientpositive/cbo_rp_udf_percentile.q.out PRE-CREATION > ql/src/test/results/clientpositive/cbo_rp_udf_percentile2.q.out > PRE-CREATION > > Diff: https://reviews.apache.org/r/40101/diff/ > > > Testing > ------- > > > Thanks, > > pengcheng xiong > >
