> On Feb. 5, 2016, 6:21 p.m., Jesús Camacho Rodríguez wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinProjectTransposeRule.java, > > line 153 > > <https://reviews.apache.org/r/43143/diff/2/?file=1231783#file1231783line153> > > > > This rule is only applied over the Project children. Thus, why is the > > parameter for the method hasAggregateChildWithIndicator e.g. leftJoinChild > > instead of leftProj? > > Jesús Camacho Rodríguez wrote: > OK, you still need to check because you might pull up every column from > one of the sides...
Please Hari, mark it as fixed if you agree. - Jesús ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43143/#review118045 ----------------------------------------------------------- On Feb. 3, 2016, 8:54 p.m., Hari Sankar Sivarama Subramaniyan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43143/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2016, 8:54 p.m.) > > > Review request for hive, Jesús Camacho Rodríguez and John Pullokkaran. > > > Repository: hive-git > > > Description > ------- > > CBO: Calcite Operator To Hive Operator (Calcite Return Path): TestCliDriver > groupby_grouping_sets4.q failure > > > Diffs > ----- > > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinProjectTransposeRule.java > f6b2d84 > > Diff: https://reviews.apache.org/r/43143/diff/ > > > Testing > ------- > > Precommit runs > > > Thanks, > > Hari Sankar Sivarama Subramaniyan > >
