-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46020/
-----------------------------------------------------------
(Updated Апрель 12, 2016, 9:14 д.п.)
Review request for hive.
Changes
-------
Added:
1. Before upload create tmp file without header or/and footer.
2. Upload modified file.
Removed:
1. Header or footer isn't skipping now in select operation.
2. FooterBuffer and few test. They are now useless.
Bugs: HIVE-10176
https://issues.apache.org/jira/browse/HIVE-10176
Repository: hive-git
Description
-------
When inserting values in to tables with TBLPROPERTIES
("skip.header.line.count"="1") the first value listed is also skipped.
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java a5489a9
ql/src/java/org/apache/hadoop/hive/ql/exec/FooterBuffer.java 6a407af
ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java 4a546d1
ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java ab0635e
ql/src/java/org/apache/hadoop/hive/ql/io/HiveContextAwareRecordReader.java
4a05a62
ql/src/test/queries/clientnegative/file_with_header_footer_negative.q 1f63d94
ql/src/test/queries/clientpositive/file_with_header_footer.q 8913e54
ql/src/test/results/clientnegative/file_with_header_footer_negative.q.out
1794ae6
ql/src/test/results/clientpositive/file_with_header_footer.q.out ca3dadb
ql/src/test/results/clientpositive/skiphf_aggr.q.out aeb4b1b
Diff: https://reviews.apache.org/r/46020/diff/
Testing (updated)
-------
All the 2 failures are not related:
org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver_index_bitmap3
org.apache.hive.jdbc.TestMultiSessionsHS2WithLocalClusterSpark.testSparkQuery.
Thanks,
Vladislav Pavlenko
