----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46020/ -----------------------------------------------------------
(Updated Май 10, 2016, 3:43 п.п.) Review request for hive. Changes ------- Fixed double copy in patch in case when file has a footer or/and header. Bugs: HIVE-10176 https://issues.apache.org/jira/browse/HIVE-10176 Repository: hive-git Description ------- When inserting values in to tables with TBLPROPERTIES ("skip.header.line.count"="1") the first value listed is also skipped1. Diffs (updated) ----- ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java d8ac6ae ql/src/java/org/apache/hadoop/hive/ql/exec/FooterBuffer.java 6a407af ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java bdda89a ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 449bef8 ql/src/java/org/apache/hadoop/hive/ql/io/HiveContextAwareRecordReader.java 4a05a62 ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java dd14124 ql/src/test/queries/clientnegative/file_with_header_footer_negative.q 1f63d94 ql/src/test/queries/clientpositive/file_with_header_footer.q 8913e54 ql/src/test/results/clientnegative/file_with_header_footer_negative.q.out 1794ae6 ql/src/test/results/clientpositive/file_with_header_footer.q.out ca3dadb ql/src/test/results/clientpositive/skiphf_aggr.q.out aeb4b1b Diff: https://reviews.apache.org/r/46020/diff/ Testing ------- All the 2 failures are not related: org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver_index_bitmap3 org.apache.hive.jdbc.TestMultiSessionsHS2WithLocalClusterSpark.testSparkQuery. UPD: Now I don't create tmp file. Add methow that upload file in hdfs directly. Thanks, Vladislav Pavlenko