----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46579/#review130365 -----------------------------------------------------------
Ship it! Looks good. One minor comment - in case you want to make a change before commit - "hs2" as a constant somewhere rather than referring the string literal separately in 2 places, and maybe call it 'hiveserver' in case there's ever an hs3 / hs2 goes away. - Siddharth Seth On April 23, 2016, 1:57 a.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46579/ > ----------------------------------------------------------- > > (Updated April 23, 2016, 1:57 a.m.) > > > Review request for hive, Gunther Hagleitner, Siddharth Seth, and Vikram Dixit > Kumaraswamy. > > > Repository: hive-git > > > Description > ------- > > see JIRA > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 926806b > llap-common/src/java/org/apache/hadoop/hive/llap/LlapUtil.java ce03de0 > > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapProtocolServerImpl.java > e99e689 > > llap-server/src/java/org/apache/hadoop/hive/llap/security/LlapSecurityHelper.java > 76ba225 > > llap-server/src/java/org/apache/hadoop/hive/llap/security/SecretManager.java > 8c7a539 > > Diff: https://reviews.apache.org/r/46579/diff/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
