> On May 6, 2016, midnight, Lefty Leverenz wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, lines 2694-2698 > > <https://reviews.apache.org/r/46579/diff/3/?file=1374107#file1374107line2694> > > > > My usual comment: please spell out the abbreviations ZK and HS2 (at > > least once each) for the benefit of newcomers. Neither one comes up near > > the top of a google search.
+1 Looks good, thanks. - Lefty ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46579/#review131971 ----------------------------------------------------------- On May 17, 2016, 12:56 a.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46579/ > ----------------------------------------------------------- > > (Updated May 17, 2016, 12:56 a.m.) > > > Review request for hive, Gunther Hagleitner, Siddharth Seth, and Vikram Dixit > Kumaraswamy. > > > Repository: hive-git > > > Description > ------- > > see JIRA > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 541af57 > llap-client/pom.xml 4a75bbb > llap-client/src/java/org/apache/hadoop/hive/llap/io/api/LlapProxy.java > 424769f > > llap-client/src/java/org/apache/hadoop/hive/llap/security/LlapTokenClientFactory.java > PRE-CREATION > > llap-client/src/java/org/apache/hadoop/hive/llap/security/LlapTokenLocalClient.java > PRE-CREATION > llap-common/src/java/org/apache/hadoop/hive/llap/DaemonId.java 18355e6 > llap-common/src/java/org/apache/hadoop/hive/llap/LlapUtil.java ce03de0 > > llap-common/src/java/org/apache/hadoop/hive/llap/impl/LlapManagementProtocolClientImpl.java > cd11bdb > > llap-common/src/java/org/apache/hadoop/hive/llap/security/LlapTokenProvider.java > edf9b18 > > llap-common/src/java/org/apache/hadoop/hive/llap/security/SecretManager.java > PRE-CREATION > > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapDaemon.java > 5731b2c > > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapProtocolServerImpl.java > db8bfa6 > > llap-server/src/java/org/apache/hadoop/hive/llap/security/LlapSecurityHelper.java > f958bc4 > > llap-server/src/java/org/apache/hadoop/hive/llap/security/SecretManager.java > c54e726 > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java fd6465a > > Diff: https://reviews.apache.org/r/46579/diff/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
