----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50982/#review145509 -----------------------------------------------------------
Hi Miklos, Thanks for the patch. This extra column was hurting my eyes :) One important note: - Please review your patch, to adhere the coding conventions here: https://cwiki.apache.org/confluence/display/Hive/HowToContribute#HowToContribute-CodingConventions What I have seen specifically: - Spaces in empty lines - Padding of lines - Missing space before '{' - Missing space between method call parameters - And in the conditional statement, the extra space made it less readable. About filling the review request: - Please fill the branch, and the bug information of this apache review as well, to help searching for it. Thanks, Peter beeline/src/test/org/apache/hive/beeline/TestTableOutputFormat.java (lines 71 - 88) <https://reviews.apache.org/r/50982/#comment211755> I would remove these empty functions beeline/src/test/org/apache/hive/beeline/TestTableOutputFormat.java (line 91) <https://reviews.apache.org/r/50982/#comment211754> nit: Maybe it would be good to have a little more explanation here, what we are testing - like extra column... beeline/src/test/org/apache/hive/beeline/TestTableOutputFormat.java (line 95) <https://reviews.apache.org/r/50982/#comment211756> nit: I would remove this line beeline/src/test/org/apache/hive/beeline/TestTableOutputFormat.java (line 99) <https://reviews.apache.org/r/50982/#comment211753> nit: I think, you should remove this line from the final patch - Peter Vary On Aug. 11, 2016, 2:19 p.m., Miklos Csanady wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50982/ > ----------------------------------------------------------- > > (Updated Aug. 11, 2016, 2:19 p.m.) > > > Review request for hive, Peter Vary and Sergio Pena. > > > Repository: hive-git > > > Description > ------- > > Fixed output table formatting header and footer lines. > > > Diffs > ----- > > beeline/src/java/org/apache/hive/beeline/TableOutputFormat.java 2753568 > beeline/src/test/org/apache/hive/beeline/TestTableOutputFormat.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/50982/diff/ > > > Testing > ------- > > See attached Unit testClass. > After building with patch, the bug eliminated. > > > Thanks, > > Miklos Csanady > >
