> On Aug. 12, 2016, 4:54 p.m., Vihang Karajgaonkar wrote: > > beeline/src/test/org/apache/hive/beeline/TestTableOutputFormat.java, line > > 100 > > <https://reviews.apache.org/r/50982/diff/1/?file=1470785#file1470785line100> > > > > Is it possible to avoid hardcoding this string? If in the future > > beelineOpts.maxColoumnWidth default values are changed, this test might > > fail. I think it will be more robust to determine this string > > programatically using the values in mockResultData and value of > > maxColumnWidth.
I have changed for shorter strings in text, so it is now independent from maxColumnWidth. - Miklos ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50982/#review145631 ----------------------------------------------------------- On Aug. 12, 2016, 8:16 p.m., Miklos Csanady wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50982/ > ----------------------------------------------------------- > > (Updated Aug. 12, 2016, 8:16 p.m.) > > > Review request for hive, Peter Vary and Sergio Pena. > > > Bugs: HIVE-14345 > https://issues.apache.org/jira/browse/HIVE-14345 > > > Repository: hive-git > > > Description > ------- > > Fixed output table formatting header and footer lines. > > > Diffs > ----- > > beeline/src/java/org/apache/hive/beeline/TableOutputFormat.java 2753568 > beeline/src/test/org/apache/hive/beeline/TestTableOutputFormat.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/50982/diff/ > > > Testing > ------- > > See attached Unit testClass. > After building with patch, the bug eliminated. > > > Thanks, > > Miklos Csanady > >
