----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50510/#review146862 -----------------------------------------------------------
Ship it! LGTM. Thanks for the change. - Vihang Karajgaonkar On July 27, 2016, 4:26 p.m., Peter Vary wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50510/ > ----------------------------------------------------------- > > (Updated July 27, 2016, 4:26 p.m.) > > > Review request for hive, Aihua Xu, Sergio Pena, and Vihang Karajgaonkar. > > > Bugs: HIVE-14360 > https://issues.apache.org/jira/browse/HIVE-14360 > > > Repository: hive-git > > > Description > ------- > > Adding the @Ignore annotation to the getConf method, so the saving should > ignore the attribute > > > Diffs > ----- > > beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java e6e24b1 > beeline/src/test/org/apache/hive/beeline/TestBeeLineOpts.java PRE-CREATION > > Diff: https://reviews.apache.org/r/50510/diff/ > > > Testing > ------- > > Manually + unit test > > > Thanks, > > Peter Vary > >
