----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51468/#review147046 -----------------------------------------------------------
An Eclipse developer at last. :) Thanks a lot for the patch. I have some questions, however... itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CliConfigs.java (line 61) <https://reviews.apache.org/r/51468/#comment214040> I cannot see the purpose of this change. Is it still related to the test execution in the IDE? (Seems there are some implementations depending on the value "". E.g. QTestUtil.) Could you please add some explanation about it? pom.xml (line 195) <https://reviews.apache.org/r/51468/#comment214039> Wouldn't it infect the other modules (production) as well? ql/src/java/org/apache/hadoop/hive/ql/hooks/EnforceReadOnlyTables.java (line 36) <https://reviews.apache.org/r/51468/#comment214041> I agree that it looks better however, I cannot see the point of this refactor. It seems that the original implementation was good enough. Do I miss something? - Gabor Szadovszky On Aug. 26, 2016, 10:13 p.m., Zoltan Haindrich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51468/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2016, 10:13 p.m.) > > > Review request for hive, Balint Molnar, Lefty Leverenz, and Prasanth_J. > > > Bugs: HIVE-14532 > https://issues.apache.org/jira/browse/HIVE-14532 > > > Repository: hive-git > > > Description > ------- > > how to execute qtests for ide wikipage draft: > http://hastebin.com/paxicutive.vhdl > > the patch itself contains: > > * some automatic property settings to configure qtest related things to be > able to execute > * maven profile to avoid shading plugin invocation during IDE project > generation > * some test.src.tables related changes > > > Diffs > ----- > > > itests/util/src/main/java/org/apache/hadoop/hive/cli/control/AbstractCliConfig.java > efbd4657f22e856b9c9ba5f74472ad5fd9f9a5b5 > > itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CliConfigs.java > 319a205225c67f123ba35a2811ee117650d46dc3 > itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java > 4d4a929c159c61f9f4af3238d4b7baff146d346e > jdbc/pom.xml b29739b3f8577c6e363b5c8ee39b63e53a17c907 > pom.xml 9ed1c19f3e312ee1f1d9932ee2ba228589a7cb49 > ql/pom.xml 02ddb805a228ed23694c8a81953dd2400d7308c6 > ql/src/java/org/apache/hadoop/hive/ql/hooks/EnforceReadOnlyTables.java > 4569ed5e41f2f4db8f3d539d7cfb693c442ba910 > > Diff: https://reviews.apache.org/r/51468/diff/ > > > Testing > ------- > > I've tested the draft using eclipse: > 3.0 -> 3.1 -> TestCliDriver(combine2,alter_concatenate_indexed_table) > 3.0 -> 3.2 -> TestCliDriver(combine2) > > I think this should work with idea too...but someone should possibly check it > ;) > > > Thanks, > > Zoltan Haindrich > >
