> On Aug. 26, 2016, 10:40 p.m., Prasanth_J wrote: > > pom.xml, lines 1292-1297 > > <https://reviews.apache.org/r/51468/diff/1/?file=1487193#file1487193line1292> > > > > Any reason to skip shading for IDE? Is it purely performance? If so how > > much will that be? IMHO it's better to debug with the jars that we ship :)
sorry..I haven't noted why I needed it...if the shading plugin is running during ide projectfile generation : * my eclipse project classpaths are missing the references to `hive-metastore` in some modules(`llap-server`, contrib and, hbase-handler) * I've tried this with idea too (2016.2 community)...and for me there were compile errors there too...(+I had to manually set the compiler to 1.7 instead 1.5) it missed `hive-metastore`'s generated thrift interfaces from the build path in `llap-server` i'm unsure about where this problem is rooted...it might be platform dependent? but it looks like both of my ide configs have problems relating to `hive-metastore`. i'm using: * debian jessie 8.5 * orcle java8 * maven 3.3.9 anyway...skipping the shading phase fixes the classpaths / and source sets. I will add some notes to the doc about possibility that the ide will do something different...and that this approach is not an equivalent to using surefire.debug - Zoltan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51468/#review147038 ----------------------------------------------------------- On Aug. 26, 2016, 10:13 p.m., Zoltan Haindrich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51468/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2016, 10:13 p.m.) > > > Review request for hive, Balint Molnar, Lefty Leverenz, and Prasanth_J. > > > Bugs: HIVE-14532 > https://issues.apache.org/jira/browse/HIVE-14532 > > > Repository: hive-git > > > Description > ------- > > how to execute qtests for ide wikipage draft: > http://hastebin.com/paxicutive.vhdl > > the patch itself contains: > > * some automatic property settings to configure qtest related things to be > able to execute > * maven profile to avoid shading plugin invocation during IDE project > generation > * some test.src.tables related changes > > > Diffs > ----- > > > itests/util/src/main/java/org/apache/hadoop/hive/cli/control/AbstractCliConfig.java > efbd4657f22e856b9c9ba5f74472ad5fd9f9a5b5 > > itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CliConfigs.java > 319a205225c67f123ba35a2811ee117650d46dc3 > itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java > 4d4a929c159c61f9f4af3238d4b7baff146d346e > jdbc/pom.xml b29739b3f8577c6e363b5c8ee39b63e53a17c907 > pom.xml 9ed1c19f3e312ee1f1d9932ee2ba228589a7cb49 > ql/pom.xml 02ddb805a228ed23694c8a81953dd2400d7308c6 > ql/src/java/org/apache/hadoop/hive/ql/hooks/EnforceReadOnlyTables.java > 4569ed5e41f2f4db8f3d539d7cfb693c442ba910 > > Diff: https://reviews.apache.org/r/51468/diff/ > > > Testing > ------- > > I've tested the draft using eclipse: > 3.0 -> 3.1 -> TestCliDriver(combine2,alter_concatenate_indexed_table) > 3.0 -> 3.2 -> TestCliDriver(combine2) > > I think this should work with idea too...but someone should possibly check it > ;) > > > Thanks, > > Zoltan Haindrich > >