----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51695/#review148639 -----------------------------------------------------------
Can you please tell us how is this different than -i or --init option in the Beeline? jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java (lines 134 - 139) <https://reviews.apache.org/r/51695/#comment216122> Do we need these methods to be public? Looks like they are being used only withing this class. setInitFile may not be needed at all since initFile comes from sessConfMap. jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java (line 211) <https://reviews.apache.org/r/51695/#comment216121> Will it work when we redirect the beeline output to a file? jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java (line 252) <https://reviews.apache.org/r/51695/#comment216123> Does this print when we redirect the output to the file? Since this is a debug message I would suggest either using LOG.debug or System.err.println. Many users redirect the output of the command to a file. They might not want to see debug messages in the output file. - Vihang Karajgaonkar On Sept. 13, 2016, 2:36 a.m., Jianguo Tian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51695/ > ----------------------------------------------------------- > > (Updated Sept. 13, 2016, 2:36 a.m.) > > > Review request for hive and cheng xu. > > > Bugs: HIVE-5867 > https://issues.apache.org/jira/browse/HIVE-5867 > > > Repository: hive-git > > > Description > ------- > > HIVE-5867: JDBC driver and beeline should support executing an initial SQL > script > > > Diffs > ----- > > jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java > ad96a6466dd1aadab71fc261f55be4639dcbe2bf > jdbc/src/java/org/apache/hive/jdbc/Utils.java > 3161566994d6c6e01de9d88a6e87295684619ffa > jdbc/src/test/org/apache/hive/jdbc/TestInitSQL.java PRE-CREATION > jdbc/src/test/resources/init.sql PRE-CREATION > > Diff: https://reviews.apache.org/r/51695/diff/ > > > Testing > ------- > > TestInitSQL.java is JUnit test class which will test method initSql() in > HiveConnection.java. > > > Thanks, > > Jianguo Tian > >
