----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52493/#review151931 -----------------------------------------------------------
beeline/src/java/org/apache/hive/beeline/BeeLine.java (line 861) <https://reviews.apache.org/r/52493/#comment220585> tailing space beeline/src/java/org/apache/hive/beeline/Commands.java (line 1040) <https://reviews.apache.org/r/52493/#comment220588> Checks -> Check beeline/src/java/org/apache/hive/beeline/Commands.java (line 1057) <https://reviews.apache.org/r/52493/#comment220586> This error msg is not user-friendly. Can you give some potential reason for such NPE like the comments do? beeline/src/java/org/apache/hive/beeline/Commands.java (line 1085) <https://reviews.apache.org/r/52493/#comment220589> Let's combine this "if" statement with the above one. beeline/src/java/org/apache/hive/beeline/Commands.java (line 1090) <https://reviews.apache.org/r/52493/#comment220587> Add space around "-" beeline/src/test/org/apache/hive/beeline/TestBeelineArgParsing.java (line 114) <https://reviews.apache.org/r/52493/#comment220595> Do we have to change the original format with "key=value;" pair? beeline/src/test/resources/hive-site.xml (line 48) <https://reviews.apache.org/r/52493/#comment220590> Do we need this change? itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeelinePasswordOption.java (line 59) <https://reviews.apache.org/r/52493/#comment220591> Why we need this configuration? itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeelinePasswordOption.java (line 254) <https://reviews.apache.org/r/52493/#comment220592> Please close this stream in finally block. itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeelinePasswordOption.java (line 262) <https://reviews.apache.org/r/52493/#comment220593> 2 space indents itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeelinePasswordOption.java (line 268) <https://reviews.apache.org/r/52493/#comment220594> 2 space indents - cheng xu On Oct. 4, 2016, 7:35 a.m., Vihang Karajgaonkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52493/ > ----------------------------------------------------------- > > (Updated Oct. 4, 2016, 7:35 a.m.) > > > Review request for hive, cheng xu and Sergio Pena. > > > Bugs: HIVE-13589 > https://issues.apache.org/jira/browse/HIVE-13589 > > > Repository: hive-git > > > Description > ------- > > This change makes the -p option for beeline an option which has a > optionalArgument. This means that user can optionally provide a connection > url which has -p followed by no password and beeline will prompt for the > password on the console when it attempts the connection. There are no changes > to previous ways of making the connection. This way of connecting gives user > the ability to connect without logging the password in the command history or > showing up the password on the screen while connecting. > > > Diffs > ----- > > beeline/src/java/org/apache/hive/beeline/BeeLine.java > 79922d267eaf13216e8a8e4826c050d334266579 > beeline/src/java/org/apache/hive/beeline/Commands.java > 039e3549209682b5ebdde937607b77c3ec094527 > beeline/src/test/org/apache/hive/beeline/TestBeelineArgParsing.java > a83f925df25be5801f885f4570fb8aaf5ab18c88 > beeline/src/test/resources/hive-site.xml > 5f310d68245275ac9dc24df45579784019eea332 > > itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeelinePasswordOption.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/52493/diff/ > > > Testing > ------- > > > Thanks, > > Vihang Karajgaonkar > >
