> On Oct. 9, 2016, 1:42 a.m., cheng xu wrote: > > beeline/src/java/org/apache/hive/beeline/Commands.java, line 1059 > > <https://reviews.apache.org/r/52493/diff/1/?file=1519232#file1519232line1059> > > > > This error msg is not user-friendly. Can you give some potential reason > > for such NPE like the comments do?
I think we should throw a RuntimeException here since there is nothing that Beeline can do here. I have updated the error message and change it to throwing RuntimeException. Let me know if you have any thoughts. > On Oct. 9, 2016, 1:42 a.m., cheng xu wrote: > > beeline/src/test/org/apache/hive/beeline/TestBeelineArgParsing.java, line > > 114 > > <https://reviews.apache.org/r/52493/diff/1/?file=1519233#file1519233line114> > > > > Do we have to change the original format with "key=value;" pair? Yes, this is required since now the password be optional. The connect(String line) method expects connect <url> <username> <password> [driver] where the driver value can be present or not. If the password is also optional there is no way to distinguish between connect <url> <username> <driver> and <url> <username> <password> case. That was the reason I changed the implementation of constructCmd method in the first version of the patch. Now, I have kept the original implementation of the method and added a new method which gets called only when -p is used without providing a password. This limits the scope of the change and also takes care of both the cases. Let me know if you have any thoughts. > On Oct. 9, 2016, 1:42 a.m., cheng xu wrote: > > beeline/src/test/resources/hive-site.xml, line 48 > > <https://reviews.apache.org/r/52493/diff/1/?file=1519234#file1519234line48> > > > > Do we need this change? Yes, this property is used by the testcases to add dummy data in test tables. This is similar to what we do in other modules too. > On Oct. 9, 2016, 1:42 a.m., cheng xu wrote: > > itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeelinePasswordOption.java, > > line 59 > > <https://reviews.apache.org/r/52493/diff/1/?file=1519235#file1519235line59> > > > > Why we need this configuration? removed it. - Vihang ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52493/#review151931 ----------------------------------------------------------- On Oct. 20, 2016, 6:02 p.m., Vihang Karajgaonkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52493/ > ----------------------------------------------------------- > > (Updated Oct. 20, 2016, 6:02 p.m.) > > > Review request for hive, cheng xu and Sergio Pena. > > > Bugs: HIVE-13589 > https://issues.apache.org/jira/browse/HIVE-13589 > > > Repository: hive-git > > > Description > ------- > > HIVE-13589 : beeline support prompt for password with '-p' option > > > Diffs > ----- > > beeline/src/java/org/apache/hive/beeline/BeeLine.java > fdbe0a2c6c37688ab511710bd43517908996f158 > beeline/src/java/org/apache/hive/beeline/Commands.java > 6c3e7f70c811ad81aa8f3ee2ec2e42d98da7d330 > > itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeelinePasswordOption.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/52493/diff/ > > > Testing > ------- > > > Thanks, > > Vihang Karajgaonkar > >
