-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52835/#review152518
-----------------------------------------------------------



Thanks Aihua for your patch.
Only some nits, and questions.

Thanks,
Peter


beeline/src/java/org/apache/hive/beeline/HiveSchemaHelper.java (lines 257 - 258)
<https://reviews.apache.org/r/52835/#comment221535>

    nit: I think it would be nicer to change the comment is a little - I was 
trying to locate the buffer for a while, until I found out that it was the 
String List :D



beeline/src/java/org/apache/hive/beeline/HiveSchemaTool.java (line 165)
<https://reviews.apache.org/r/52835/#comment221536>

    nit: space



beeline/src/java/org/apache/hive/beeline/HiveSchemaTool.java (line 167)
<https://reviews.apache.org/r/52835/#comment221537>

    nit: extra spaces. I see that it was the same before, but rb shows this 
line as a new one so it might be ok to change this.



beeline/src/java/org/apache/hive/beeline/HiveSchemaTool.java 
<https://reviews.apache.org/r/52835/#comment221539>

    Is it not a problem, that we check the version if it is a dry run? The 
comment said it was intentional, and it changes previous behavior



beeline/src/java/org/apache/hive/beeline/HiveSchemaTool.java (line 256)
<https://reviews.apache.org/r/52835/#comment221541>

    Is the metastore state is really inconsistent? I thought we are trying to 
prevent this, and hopefully rollback solves this.



beeline/src/java/org/apache/hive/beeline/HiveSchemaTool.java (line 365)
<https://reviews.apache.org/r/52835/#comment221542>

    Is it possible to set automcommit false to every database which could be 
used as a metastore db in every configuration? Sounds reasonable, since we want 
that feature elsewhere too, but might cause a big headache here if the 
autocommit is true (no dry run, and no rollback in case of faliure)


- Peter Vary


On Oct. 13, 2016, 3:25 p.m., Aihua Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52835/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2016, 3:25 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-14926: Keep Schema in consistent state where schemaTool fails or succeeds
> 
> 
> Diffs
> -----
> 
>   beeline/src/java/org/apache/hive/beeline/HiveSchemaHelper.java 
> 181f0d28243cb5f9c4a14fa142b6b94009d77ea4 
>   beeline/src/java/org/apache/hive/beeline/HiveSchemaTool.java 
> cd36ddf3860cf56c7d4a7eadcc5bbb173e93a860 
>   
> metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreSchemaInfo.java 
> 9c30ee7add2eda912ab0a27283d1c0f4c689baee 
> 
> Diff: https://reviews.apache.org/r/52835/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aihua Xu
> 
>

Reply via email to