> On Oct. 13, 2016, 8:42 p.m., Aihua Xu wrote: > > beeline/src/java/org/apache/hive/beeline/HiveSchemaTool.java, line 289 > > <https://reviews.apache.org/r/52835/diff/1/?file=1534847#file1534847line289> > > > > Yeah. I thought about changing the error. But we are committing one > > script file at a time and you can continue to run from the failed script if > > one fails. So for a whole upgrade process, that could be still in half way > > (e.g., upgrade from 0.7 to 2.2, failed at 1.3. Then you can try to upgrade > > from 1.3 to 2.2). So I intentionally leave like this.
That is new for me, thanks for the info! Do we know here which scripts are run, and which are not? Then it would be helpful to tell it to the user how to continue the upgrade - Maybe it worth another jira > On Oct. 13, 2016, 8:42 p.m., Aihua Xu wrote: > > beeline/src/java/org/apache/hive/beeline/HiveSchemaTool.java, line 214 > > <https://reviews.apache.org/r/52835/diff/1/?file=1534847#file1534847line214> > > > > Now the dry run will execute the scripts but without commit. So it will > > get the correct schema version like real run. > > > > Before this change dry run actually only lists the scripts it will > > execute. We should not forget to change the documentation then to match the feature change: https://cwiki.apache.org/confluence/display/Hive/Hive+Schema+Tool - Peter ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52835/#review152574 ----------------------------------------------------------- On Oct. 13, 2016, 8:43 p.m., Aihua Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52835/ > ----------------------------------------------------------- > > (Updated Oct. 13, 2016, 8:43 p.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > HIVE-14926: Keep Schema in consistent state where schemaTool fails or succeeds > > > Diffs > ----- > > beeline/src/java/org/apache/hive/beeline/HiveSchemaHelper.java 181f0d2 > beeline/src/java/org/apache/hive/beeline/HiveSchemaTool.java cd36ddf > itests/hive-unit/src/test/java/org/apache/hive/beeline/TestSchemaTool.java > 0d5f9c8 > > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreSchemaInfo.java > 9c30ee7 > > Diff: https://reviews.apache.org/r/52835/diff/ > > > Testing > ------- > > > Thanks, > > Aihua Xu > >
