> On Oct. 14, 2016, 8:23 p.m., Ashutosh Chauhan wrote:
> > ql/src/test/queries/clientpositive/insert1.q, lines 49-51
> > <https://reviews.apache.org/r/52708/diff/1/?file=1530003#file1530003line49>
> >
> >     insert overwrite local dir is best tested on cluster. So, doesnt make 
> > sense in ut.

So should we keep this in system tests ?


- Vineet


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52708/#review152425
-----------------------------------------------------------


On Oct. 18, 2016, 5:46 p.m., Vineet Garg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52708/
> -----------------------------------------------------------
> 
> (Updated Oct. 18, 2016, 5:46 p.m.)
> 
> 
> Review request for hive and Ashutosh Chauhan.
> 
> 
> Bugs: HIVE-14913
>     https://issues.apache.org/jira/browse/HIVE-14913
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Moved bunch of system tests to hive unit tests
> 
> 
> Diffs
> -----
> 
>   itests/src/test/resources/testconfiguration.properties 97e310d 
>   ql/src/test/queries/clientpositive/cte_1.q ca4132f 
>   ql/src/test/queries/clientpositive/cte_2.q b49620a 
>   ql/src/test/queries/clientpositive/current_date_timestamp.q 9bed885 
>   ql/src/test/queries/clientpositive/insert1.q 4117b54 
>   ql/src/test/queries/clientpositive/join_acid_non_acid.q 866b466 
>   ql/src/test/queries/clientpositive/lvj_mapjoin.q b726e2a 
>   ql/src/test/queries/clientpositive/orc_ppd_basic.q 43f2c85 
>   ql/src/test/queries/clientpositive/schema_evol_orc_acid_part_update.q 
> d971649 
>   ql/src/test/queries/clientpositive/vectorization_0.q caa6a6a 
>   ql/src/test/results/clientpositive/cte_1.q.out 6e7acf6 
>   ql/src/test/results/clientpositive/cte_2.q.out 4b0bc71 
>   ql/src/test/results/clientpositive/current_date_timestamp.q.out 9c26095 
>   ql/src/test/results/clientpositive/insert1.q.out 7a2c429 
>   ql/src/test/results/clientpositive/llap/cte_1.q.out 41ffdc7 
>   ql/src/test/results/clientpositive/llap/cte_2.q.out 017bded 
>   ql/src/test/results/clientpositive/llap/current_date_timestamp.q.out 
> PRE-CREATION 
>   ql/src/test/results/clientpositive/llap/insert1.q.out 4b30156 
>   ql/src/test/results/clientpositive/llap/join_acid_non_acid.q.out 4905351 
>   ql/src/test/results/clientpositive/llap/lvj_mapjoin.q.out dd4d024 
>   ql/src/test/results/clientpositive/llap/orc_ppd_basic.q.out aa37ff3 
>   
> ql/src/test/results/clientpositive/llap/schema_evol_orc_acid_part_update.q.out
>  ed698e1 
>   ql/src/test/results/clientpositive/llap/vectorization_0.q.out faceb5c 
>   ql/src/test/results/clientpositive/spark/alter_merge_orc.q.out b5a6d04 
>   ql/src/test/results/clientpositive/spark/vectorization_0.q.out 22fe7cd 
>   ql/src/test/results/clientpositive/vectorization_0.q.out ac33721 
> 
> Diff: https://reviews.apache.org/r/52708/diff/
> 
> 
> Testing
> -------
> 
> Pre-commit testing
> 
> 
> Thanks,
> 
> Vineet Garg
> 
>

Reply via email to