> On Dec. 22, 2016, 9:27 p.m., Aihua Xu wrote: > > hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/AbstractHCatLoaderTest.java, > > line 5 > > <https://reviews.apache.org/r/54997/diff/1/?file=1591307#file1591307line5> > > > > This is very clean. The only question is: seems TestHCatLoader.java is > > not needed any more since we are not testing anything there. If there is a > > new format, we can add a subclass to test it. Can we remove > > TestHCatLoader.java? > > > > Otherwise, everything looks good.
I agree. I will remove it and post it again. - Vihang ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54997/#review160014 ----------------------------------------------------------- On Dec. 22, 2016, 9:11 p.m., Vihang Karajgaonkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54997/ > ----------------------------------------------------------- > > (Updated Dec. 22, 2016, 9:11 p.m.) > > > Review request for hive and Aihua Xu. > > > Bugs: HIVE-14956 > https://issues.apache.org/jira/browse/HIVE-14956 > > > Repository: hive-git > > > Description > ------- > > HIVE-14956 : Parallelize TestHCatLoader > > > Diffs > ----- > > > hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/AbstractHCatLoaderTest.java > PRE-CREATION > > hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestAvroHCatLoader.java > PRE-CREATION > > hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestHCatLoader.java > 71b09b0568defe2c02a3aa1ffc32a36a95690b8b > > hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestOrcHCatLoader.java > PRE-CREATION > > hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestParquetHCatLoader.java > PRE-CREATION > > hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestRCFileHCatLoader.java > PRE-CREATION > > hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestSequenceFileHCatLoader.java > PRE-CREATION > > hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestTextFileHCatLoader.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/54997/diff/ > > > Testing > ------- > > > Thanks, > > Vihang Karajgaonkar > >
