----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55154/#review160450 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/parse/ReplicationSemanticAnalyzer.java (line 573) <https://reviews.apache.org/r/55154/#comment231594> Instead of using JSONMessageFactory.getTableName, please instantiate the InsertMessage (not JSONInsertMessage) and ask it for getTableName() - that way, we stick to portable MessageFactory based api. Also, if you look at the alter patch and how it changes add_ptns, you'll see how to get the partitions objects/etc generically. - Sushanth Sowmyan On Jan. 3, 2017, 10:27 p.m., Vaibhav Gumashta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55154/ > ----------------------------------------------------------- > > (Updated Jan. 3, 2017, 10:27 p.m.) > > > Review request for hive, Daniel Dai, Sushanth Sowmyan, and Thejas Nair. > > > Bugs: HIVE-15366 > https://issues.apache.org/jira/browse/HIVE-15366 > > > Repository: hive-git > > > Description > ------- > > https://issues.apache.org/jira/browse/HIVE-15366 > > > Diffs > ----- > > > metastore/src/java/org/apache/hadoop/hive/metastore/messaging/InsertMessage.java > fe747df > > metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONInsertMessage.java > bd9f9ec > > metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONMessageFactory.java > 9954902 > ql/src/java/org/apache/hadoop/hive/ql/exec/ReplCopyTask.java 4c0f817 > ql/src/java/org/apache/hadoop/hive/ql/parse/EximUtil.java 6e9602f > ql/src/java/org/apache/hadoop/hive/ql/parse/ExportSemanticAnalyzer.java > f61274b > ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.java > 5561e06 > > ql/src/java/org/apache/hadoop/hive/ql/parse/ReplicationSemanticAnalyzer.java > 9b83407 > > Diff: https://reviews.apache.org/r/55154/diff/ > > > Testing > ------- > > > Thanks, > > Vaibhav Gumashta > >
