> On Jan. 9, 2017, 7:07 p.m., Sushanth Sowmyan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java, line 2352 > > <https://reviews.apache.org/r/55154/diff/4/?file=1598535#file1598535line2352> > > > > We probably don't have a problem here, in that all entries in the list > > of newFiles are all probably in the same filesystem, but if ever that > > changes, we can have off-by-one issues here wherein we cannot line up the > > file to its checksum, if some files have checksums and others in the middle > > don't. Would it make sense to put in a "" or something like that to > > indicate that there was no checksum for this file? > > > > Note - this is not a blocker issue, and the patch can continue as-is. I > > mention more because this is something that might change in the future.
Fixing in this jira itself since it's a tiny change. - Vaibhav ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55154/#review160929 ----------------------------------------------------------- On Jan. 6, 2017, 6:43 a.m., Vaibhav Gumashta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55154/ > ----------------------------------------------------------- > > (Updated Jan. 6, 2017, 6:43 a.m.) > > > Review request for hive, Daniel Dai, Sushanth Sowmyan, and Thejas Nair. > > > Bugs: HIVE-15366 > https://issues.apache.org/jira/browse/HIVE-15366 > > > Repository: hive-git > > > Description > ------- > > https://issues.apache.org/jira/browse/HIVE-15366 > > > Diffs > ----- > > > itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/TestDbNotificationListener.java > 39356ae > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/TestReplicationScenarios.java > e29aa22 > metastore/if/hive_metastore.thrift 79592ea > metastore/src/gen/thrift/gen-cpp/hive_metastore_types.cpp 1311b20 > > metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/InsertEventRequestData.java > 39a607d > metastore/src/gen/thrift/gen-rb/hive_metastore_types.rb ebed504 > metastore/src/java/org/apache/hadoop/hive/metastore/events/InsertEvent.java > d9a42a7 > > metastore/src/java/org/apache/hadoop/hive/metastore/messaging/InsertMessage.java > fe747df > > metastore/src/java/org/apache/hadoop/hive/metastore/messaging/MessageFactory.java > fdb8e80 > > metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONInsertMessage.java > bd9f9ec > > metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONMessageFactory.java > 9954902 > ql/src/java/org/apache/hadoop/hive/ql/exec/ReplCopyTask.java 4c0f817 > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java be5a6a9 > ql/src/java/org/apache/hadoop/hive/ql/parse/EximUtil.java 6e9602f > ql/src/java/org/apache/hadoop/hive/ql/parse/ExportSemanticAnalyzer.java > f61274b > ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.java > 5561e06 > > ql/src/java/org/apache/hadoop/hive/ql/parse/ReplicationSemanticAnalyzer.java > 9b83407 > > Diff: https://reviews.apache.org/r/55154/diff/ > > > Testing > ------- > > > Thanks, > > Vaibhav Gumashta > >