-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55498/#review161514
-----------------------------------------------------------



The patch is nice and clean.
The line lenghts does not conform to the accepted 100 character, but this is 
the only nit I could find :)

About the actual queries, I do not know this part of the code enough to help 
here. Someone with more knowledge is needed there.

Thanks for the patch!

- Peter Vary


On Jan. 13, 2017, 11:58 a.m., Marta Kuczora wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55498/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2017, 11:58 a.m.)
> 
> 
> Review request for hive and Chaoyu Tang.
> 
> 
> Bugs: HIVE-15538
>     https://issues.apache.org/jira/browse/HIVE-15538
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Added unit test for testing HIVE-13884 with more complex queries and 
> hive.metastore.limit.partition.request enabled.
> It covers cases when the query predicates can be pushed down and the number 
> of partitions can be retrieved via directSQL.
> It also covers cases when the number of partitions cannot be retrieved via 
> directSQL, so it falls back to ORM.
> 
> 
> Diffs
> -----
> 
>   data/files/max_partition_test_input.txt PRE-CREATION 
>   
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/TestMetaStoreLimitPartitionRequest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/55498/diff/
> 
> 
> Testing
> -------
> 
> The patch contains only a new unit test. Ran the test multiple times 
> successfully.
> 
> 
> Thanks,
> 
> Marta Kuczora
> 
>

Reply via email to