----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55498/#review163279 -----------------------------------------------------------
Thanks for the patch and it looks good. However, I have a couple of questions which need your clarifications. Thanks data/files/max_partition_test_input.txt (line 1) <https://reviews.apache.org/r/55498/#comment234711> As I remember there was an upstream discussion, we should try to avoid to add a new test data file? itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/TestMetaStoreLimitPartitionRequest.java (line 193) <https://reviews.apache.org/r/55498/#comment234709> How could you tell from the test directly that the query has been falled back to ORM? itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/TestMetaStoreLimitPartitionRequest.java (line 230) <https://reviews.apache.org/r/55498/#comment234716> HMS filter might support the IN clause, but not the LIKE in query predicate. - Chaoyu Tang On Jan. 13, 2017, 3:26 p.m., Marta Kuczora wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55498/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2017, 3:26 p.m.) > > > Review request for hive and Chaoyu Tang. > > > Bugs: HIVE-15538 > https://issues.apache.org/jira/browse/HIVE-15538 > > > Repository: hive-git > > > Description > ------- > > Added unit test for testing HIVE-13884 with more complex queries and > hive.metastore.limit.partition.request enabled. > It covers cases when the query predicates can be pushed down and the number > of partitions can be retrieved via directSQL. > It also covers cases when the number of partitions cannot be retrieved via > directSQL, so it falls back to ORM. > > > Diffs > ----- > > data/files/max_partition_test_input.txt PRE-CREATION > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/TestMetaStoreLimitPartitionRequest.java > PRE-CREATION > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 121b825 > > Diff: https://reviews.apache.org/r/55498/diff/ > > > Testing > ------- > > The patch contains only a new unit test. Ran the test multiple times > successfully. > > > Thanks, > > Marta Kuczora > >
