----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56095/#review164707 -----------------------------------------------------------
itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/TestDbNotificationListener.java (line 586) <https://reviews.apache.org/r/56095/#comment236467> Can you please refactor out the repeating statements into util methods to improve readability of this test case? metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java (line 2980) <https://reviews.apache.org/r/56095/#comment236466> Does it need to fire exchangePartitionEvent here when success is true as well? If you look at the add_partitions_core method it creates a addPartition event for transaction listeners and also for listeners in the finally clause when success is true. Is there a reason this is different? - Vihang Karajgaonkar On Feb. 7, 2017, 9:32 p.m., Nachiket Vaidya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56095/ > ----------------------------------------------------------- > > (Updated Feb. 7, 2017, 9:32 p.m.) > > > Review request for hive, Mohit Sabharwal and Sergio Pena. > > > Bugs: HIVE-15754 > https://issues.apache.org/jira/browse/HIVE-15754 > > > Repository: hive-git > > > Description > ------- > > HIVE-15754 exchange partition is not generating notifications > > exchange partition event is not generating notifications in notification_log. > There should multiple events generated. one add_partition event and several > drop_partition events. > for example: > ALTER TABLE tab1 EXCHANGE PARTITION (part=1) WITH TABLE tab2; > > There should be the following events: > ADD_PARTITION on tab2 on partition (part=1) > DROP_PARTITION on tab1 on partition (part=1) > > > Diffs > ----- > > > itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/TestDbNotificationListener.java > 640b567ebf9af1af5a3dd9fa1442eb5c5b8ef1a4 > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 13d0aab40eaf344869b8230614b55115f64857e6 > > Diff: https://reviews.apache.org/r/56095/diff/ > > > Testing > ------- > > o Added unit test cases. > o Ran exchange partition queries and saw entired in notification_log. > > > Thanks, > > Nachiket Vaidya > >
