> On Feb. 17, 2017, 11:54 a.m., Ashutosh Chauhan wrote: > > druid-handler/src/java/org/apache/hadoop/hive/druid/io/DruidQueryBasedInputFormat.java, > > line 207 > > <https://reviews.apache.org/r/56784/diff/1/?file=1638374#file1638374line207> > > > > Shall we rethrow here? Can we still continue?
We should, I will change it accordingly. > On Feb. 17, 2017, 11:54 a.m., Ashutosh Chauhan wrote: > > druid-handler/src/java/org/apache/hadoop/hive/druid/io/DruidQueryBasedInputFormat.java, > > line 245 > > <https://reviews.apache.org/r/56784/diff/1/?file=1638374#file1638374line245> > > > > It might be a better idea to pass locatedSD.getLocations() list to > > HiveDruidSplit and then override > > FileSplit::getLocations()/getLocationInfo() there to return this list. > > > > This will make sure that in colocated cluster, Tez has info to colocate > > tez tasks with druid historical node. In current impl, it will make use of > > dummyPath and will be totally unpredictable. I will do that and upload a new patch. Thanks - Jesús ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56784/#review165926 ----------------------------------------------------------- On Feb. 17, 2017, 11:22 a.m., Jesús Camacho Rodríguez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56784/ > ----------------------------------------------------------- > > (Updated Feb. 17, 2017, 11:22 a.m.) > > > Review request for hive, Ashutosh Chauhan and Slim Bouguerra. > > > Bugs: HIVE-15928 > https://issues.apache.org/jira/browse/HIVE-15928 > > > Repository: hive-git > > > Description > ------- > > HIVE-15928 > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > 0bff243f08188c98ffe16c6602f628412881fc66 > > druid-handler/src/java/org/apache/hadoop/hive/druid/io/DruidQueryBasedInputFormat.java > 8b378407c4ff7c7764e7d48feb3e4cbe16f82016 > > Diff: https://reviews.apache.org/r/56784/diff/ > > > Testing > ------- > > > Thanks, > > Jesús Camacho Rodríguez > >
