----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56785/#review165937 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/SqlFunctionConverter.java (line 490) <https://reviews.apache.org/r/56785/#comment237787> Is it too difficult to add more info to CalciteUDFInfo, e.g. SQLKind, etc., so we do not need specific CASE per operator here and we have a simply a default logic? I think that would be more robust. - Jesús Camacho Rodríguez On Feb. 17, 2017, 11:59 a.m., Ashutosh Chauhan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56785/ > ----------------------------------------------------------- > > (Updated Feb. 17, 2017, 11:59 a.m.) > > > Review request for hive and Jesús Camacho Rodríguez. > > > Bugs: HIVE-15957 > https://issues.apache.org/jira/browse/HIVE-15957 > > > Repository: hive-git > > > Description > ------- > > This was already done for - operator in HIVE-15258. This patch just extends > it for + as well. > > > Diffs > ----- > > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/SqlFunctionConverter.java > 5c85dce > ql/src/test/queries/clientpositive/interval_arithmetic.q 06acbd7 > ql/src/test/results/clientpositive/interval_alt.q.out 9884ec3 > ql/src/test/results/clientpositive/interval_arithmetic.q.out 64882f8 > ql/src/test/results/clientpositive/llap/metadata_only_queries.q.out 25be543 > ql/src/test/results/clientpositive/metadata_only_queries.q.out 2e3331e > ql/src/test/results/clientpositive/spark/metadata_only_queries.q.out > dc96a0d > > Diff: https://reviews.apache.org/r/56785/diff/ > > > Testing > ------- > > New test + regression suite. > > > Thanks, > > Ashutosh Chauhan > >
