> On March 15, 2017, 4:05 a.m., Naveen Gangam wrote: > > common/src/java/org/apache/hadoop/hive/common/FixedSizeCollection.java > > Lines 32 (patched) > > <https://reviews.apache.org/r/57503/diff/1/?file=1661199#file1661199line32> > > > > Since we already use common-collections library in hive, would using > > something like FixedSizeList or something else address the same purpose > > instead of having to add a new class?
Let's wait and see how we decide on the need for this fixed size collection. If we are happy with using just the PartitionIterable, then these collections are not needed anymore. - Barna Zsombor ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57503/#review168969 ----------------------------------------------------------- On March 10, 2017, 10:36 a.m., Barna Zsombor Klara wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57503/ > ----------------------------------------------------------- > > (Updated March 10, 2017, 10:36 a.m.) > > > Review request for hive, Peter Vary, Sergio Pena, Sahil Takiar, and Vihang > Karajgaonkar. > > > Repository: hive-git > > > Description > ------- > > HIVE-16024: MSCK Repair Requires nonstrict hive.mapred.mode > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/common/FixedSizeCollection.java > PRE-CREATION > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > a479deb7c0c6b779277f1029009b7dfab6dcb9e3 > common/src/test/org/apache/hadoop/hive/common/TestFixedSizeCollection.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMetaStoreChecker.java > 6805c17a116f5ef0febd36c59d454fa631ae0024 > ql/src/test/queries/clientnegative/msck_repair_4.q PRE-CREATION > ql/src/test/queries/clientpositive/msck_repair_0.q > ce8ef426a2a58845afc8333259d66725db416584 > ql/src/test/results/clientnegative/msck_repair_4.q.out PRE-CREATION > ql/src/test/results/clientpositive/msck_repair_0.q.out > 3f2fe75b194f1248bd5c073dd7db6b71b2ffc2ba > > > Diff: https://reviews.apache.org/r/57503/diff/1/ > > > Testing > ------- > > Tested locally and added qtests/unit tests. > > > Thanks, > > Barna Zsombor Klara > >
