> On March 17, 2017, 8:30 p.m., Sergio Pena wrote: > > ql/src/test/queries/clientpositive/msck_repair_0.q > > Lines 19-21 (patched) > > <https://reviews.apache.org/r/57503/diff/2/?file=1666109#file1666109line19> > > > > Is this actually adding new partitios to the metastore? Those are > > already discovered above. I think this part is not testing the changes > > correctly.
The check was initially failing in strict mode even if there were no partitions to be discovered/repaired, but I can change the test to find new partitions missing from the HMS. - Barna Zsombor ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57503/#review169324 ----------------------------------------------------------- On March 16, 2017, 3:55 p.m., Barna Zsombor Klara wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57503/ > ----------------------------------------------------------- > > (Updated March 16, 2017, 3:55 p.m.) > > > Review request for hive, Peter Vary, Sergio Pena, Sahil Takiar, and Vihang > Karajgaonkar. > > > Repository: hive-git > > > Description > ------- > > HIVE-16024: MSCK Repair Requires nonstrict hive.mapred.mode > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMetaStoreChecker.java > 6805c17a116f5ef0febd36c59d454fa631ae0024 > ql/src/test/queries/clientpositive/msck_repair_0.q > ce8ef426a2a58845afc8333259d66725db416584 > ql/src/test/results/clientpositive/msck_repair_0.q.out > 3f2fe75b194f1248bd5c073dd7db6b71b2ffc2ba > > > Diff: https://reviews.apache.org/r/57503/diff/2/ > > > Testing > ------- > > Tested locally and added qtests/unit tests. > > > Thanks, > > Barna Zsombor Klara > >
