-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58686/
-----------------------------------------------------------

(Updated April 28, 2017, 6:19 p.m.)


Review request for hive and pengcheng xiong.


Changes
-------

Furhter changes to fix the test failures:
1. partititon view does not have SD, so we need check if SD is null or not 
before further calling its getCols()
2. ObjectStore.getMPartitionColumnStatistics validated the partition columns 
against Table which I thought is not correct. Partition might have a different 
column definition from Table. In this case, we should raise some warning 
instead of throwing out the exception.


Bugs: HIVE-16147
    https://issues.apache.org/jira/browse/HIVE-16147


Repository: hive-git


Description
-------

The patch is to
1. preserve the column stats after a partitioned table is renamed
2. rename the alter_table_invalidate_column_stats.q to 
alter_table_column_stats.q


Diffs (updated)
-----

  metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java 
77b3541 
  metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java 
1b701e0 
  metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 6b21751 
  ql/src/test/queries/clientpositive/alter_table_column_stats.q PRE-CREATION 
  ql/src/test/queries/clientpositive/alter_table_invalidate_column_stats.q 
a478451 
  ql/src/test/results/clientpositive/alter_table_column_stats.q.out 
PRE-CREATION 
  ql/src/test/results/clientpositive/alter_table_invalidate_column_stats.q.out 
85d7dc4 


Diff: https://reviews.apache.org/r/58686/diff/2/

Changes: https://reviews.apache.org/r/58686/diff/1-2/


Testing
-------

manual tests
qtests


Thanks,

Chaoyu Tang

Reply via email to