----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58686/#review173359 -----------------------------------------------------------
metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java Lines 7386 (patched) <https://reviews.apache.org/r/58686/#comment246372> The other parts look good to me. Could u explain with an example why we swallow the exception here? thanks. - pengcheng xiong On April 28, 2017, 6:19 p.m., Chaoyu Tang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58686/ > ----------------------------------------------------------- > > (Updated April 28, 2017, 6:19 p.m.) > > > Review request for hive and pengcheng xiong. > > > Bugs: HIVE-16147 > https://issues.apache.org/jira/browse/HIVE-16147 > > > Repository: hive-git > > > Description > ------- > > The patch is to > 1. preserve the column stats after a partitioned table is renamed > 2. rename the alter_table_invalidate_column_stats.q to > alter_table_column_stats.q > > > Diffs > ----- > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java > 77b3541 > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java > 1b701e0 > metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java > 6b21751 > ql/src/test/queries/clientpositive/alter_table_column_stats.q PRE-CREATION > ql/src/test/queries/clientpositive/alter_table_invalidate_column_stats.q > a478451 > ql/src/test/results/clientpositive/alter_table_column_stats.q.out > PRE-CREATION > > ql/src/test/results/clientpositive/alter_table_invalidate_column_stats.q.out > 85d7dc4 > > > Diff: https://reviews.apache.org/r/58686/diff/2/ > > > Testing > ------- > > manual tests > qtests > > > Thanks, > > Chaoyu Tang > >
