----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58914/#review173628 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java Lines 11192 (patched) <https://reviews.apache.org/r/58914/#comment246628> Can you give the method name something different than OldHints - how about getHintsFromQB? ql/src/test/queries/clientpositive/semijoin_hint.q Lines 46 (patched) <https://reviews.apache.org/r/58914/#comment246638> Does this query, with no hints, have any runtime filtering? Otherwise you wouldn't be able to distinguish whether the None option works or not. ql/src/test/results/clientpositive/llap/semijoin_hint.q.out Lines 233 (patched) <https://reviews.apache.org/r/58914/#comment246641> Should the expectedEntries be 5000 per the hint? ql/src/test/results/clientpositive/llap/semijoin_hint.q.out Lines 266 (patched) <https://reviews.apache.org/r/58914/#comment246642> Should the expectedEntries be 5000 per the hint? ql/src/test/results/clientpositive/llap/semijoin_hint.q.out Lines 300 (patched) <https://reviews.apache.org/r/58914/#comment246643> Should the expectedEntries be 5000 per the hint? - Jason Dere On May 2, 2017, 5:47 a.m., Deepak Jaiswal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58914/ > ----------------------------------------------------------- > > (Updated May 2, 2017, 5:47 a.m.) > > > Review request for hive, Jason Dere and Sergey Shelukhin. > > > Bugs: HIVE-16550 > https://issues.apache.org/jira/browse/HIVE-16550 > > > Repository: hive-git > > > Description > ------- > > Semijoin Hints should be able to skip the optimization if needed. > In addition to that, the patch fixes several issues with hints in general > such as, > - It now works with subqueries and unions. > - Uses a global data structure instead of per QB. > > > Diffs > ----- > > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/DynamicPartitionPruningOptimization.java > e1a69526bc > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/HiveOpConverter.java > d375d1b58d > ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 1b054a7e24 > ql/src/java/org/apache/hadoop/hive/ql/parse/HintParser.g e110fb33df > ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java 3a1f821bd3 > ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java 54e37f7c80 > ql/src/java/org/apache/hadoop/hive/ql/parse/QBParseInfo.java 7bf1c599a5 > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java > 654f3b1772 > ql/src/java/org/apache/hadoop/hive/ql/parse/TaskCompiler.java 5ea7800528 > ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeDynamicListDesc.java > 3143554ec6 > ql/src/java/org/apache/hadoop/hive/ql/plan/JoinDesc.java 032c7bb28d > ql/src/java/org/apache/hadoop/hive/ql/ppd/SyntheticJoinPredicate.java > f45daa8828 > ql/src/test/queries/clientpositive/semijoin_hint.q 5de0c8c8c1 > ql/src/test/results/clientpositive/llap/semijoin_hint.q.out bc248930ec > > > Diff: https://reviews.apache.org/r/58914/diff/1/ > > > Testing > ------- > > > Thanks, > > Deepak Jaiswal > >
