----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58914/ -----------------------------------------------------------
(Updated May 3, 2017, 1:16 a.m.) Review request for hive, Jason Dere and Sergey Shelukhin. Changes ------- Worked on Jason's comments and added some more tests. Bugs: HIVE-16550 https://issues.apache.org/jira/browse/HIVE-16550 Repository: hive-git Description ------- Semijoin Hints should be able to skip the optimization if needed. In addition to that, the patch fixes several issues with hints in general such as, - It now works with subqueries and unions. - Uses a global data structure instead of per QB. Diffs (updated) ----- ql/src/java/org/apache/hadoop/hive/ql/optimizer/DynamicPartitionPruningOptimization.java e1a69526bc ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/HiveOpConverter.java 40c0f3ba2a ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 1b054a7e24 ql/src/java/org/apache/hadoop/hive/ql/parse/HintParser.g e110fb33df ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java 3a1f821bd3 ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java 54e37f7c80 ql/src/java/org/apache/hadoop/hive/ql/parse/QBParseInfo.java 7bf1c599a5 ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java cbbb7d0c94 ql/src/java/org/apache/hadoop/hive/ql/parse/TaskCompiler.java 5ea7800528 ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeDynamicListDesc.java 3143554ec6 ql/src/java/org/apache/hadoop/hive/ql/plan/JoinDesc.java 7d4267d6a8 ql/src/java/org/apache/hadoop/hive/ql/ppd/SyntheticJoinPredicate.java f45daa8828 ql/src/test/queries/clientpositive/semijoin_hint.q 5de0c8c8c1 ql/src/test/results/clientpositive/llap/semijoin_hint.q.out bc248930ec Diff: https://reviews.apache.org/r/58914/diff/3/ Changes: https://reviews.apache.org/r/58914/diff/2-3/ Testing ------- Thanks, Deepak Jaiswal