----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58973/#review173818 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/optimizer/DynamicPartitionPruningOptimization.java Lines 225 (patched) <https://reviews.apache.org/r/58973/#comment246865> Can't totally tell the nesting here, but it seems like if getColumnName() returns false this will not do semijoin reduction for this column, regardless of if there is a hint or not .. is that intended? ql/src/java/org/apache/hadoop/hive/ql/optimizer/DynamicPartitionPruningOptimization.java Lines 235 (patched) <https://reviews.apache.org/r/58973/#comment246858> Remove your name from the log line. ql/src/java/org/apache/hadoop/hive/ql/optimizer/DynamicPartitionPruningOptimization.java Lines 306 (patched) <https://reviews.apache.org/r/58973/#comment246862> Not sure if you can do this and truly say this is the column for this expression - the expression could be a function, such as replace(col1, col2). How about ExprNodeDescUtils.getColumnExpr()? ql/src/java/org/apache/hadoop/hive/ql/optimizer/DynamicPartitionPruningOptimization.java Lines 320 (patched) <https://reviews.apache.org/r/58973/#comment246868> same here, about ExprNodeDescUtils.getColumnExpr() - Jason Dere On May 3, 2017, 8:12 p.m., Deepak Jaiswal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58973/ > ----------------------------------------------------------- > > (Updated May 3, 2017, 8:12 p.m.) > > > Review request for hive and Jason Dere. > > > Repository: hive-git > > > Description > ------- > > Semijoin Hints should use column name, if provided for partition key check. > Involves some code refactoring. > > > Diffs > ----- > > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/DynamicPartitionPruningOptimization.java > b8c01020b7 > > > Diff: https://reviews.apache.org/r/58973/diff/1/ > > > Testing > ------- > > > Thanks, > > Deepak Jaiswal > >
