> On May 4, 2017, 7:20 p.m., Jason Dere wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/DynamicPartitionPruningOptimization.java > > Line 234 (original), 234 (patched) > > <https://reviews.apache.org/r/58973/diff/1-2/?file=1707234#file1707234line234> > > > > is colName ever non-null, after the change on line 226? Was under the > > impression that an empty StringBuilder would simply return an empty string, > > so this would always be non-null.
Thanks for bringing this up. I will fix it. - Deepak ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58973/#review173944 ----------------------------------------------------------- On May 4, 2017, 7:34 a.m., Deepak Jaiswal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58973/ > ----------------------------------------------------------- > > (Updated May 4, 2017, 7:34 a.m.) > > > Review request for hive and Jason Dere. > > > Repository: hive-git > > > Description > ------- > > Semijoin Hints should use column name, if provided for partition key check. > Involves some code refactoring. > > > Diffs > ----- > > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/DynamicPartitionPruningOptimization.java > b8c01020b7 > ql/src/test/queries/clientpositive/semijoin_hint.q a3cd1d664d > ql/src/test/results/clientpositive/llap/dynamic_semijoin_reduction.q.out > 1d1f86bfaa > ql/src/test/results/clientpositive/llap/dynamic_semijoin_reduction_2.q.out > a5fdd90811 > ql/src/test/results/clientpositive/llap/dynamic_semijoin_reduction_3.q.out > 8950b70b09 > ql/src/test/results/clientpositive/llap/dynamic_semijoin_user_level.q.out > b910df4f34 > ql/src/test/results/clientpositive/llap/semijoin_hint.q.out 388888ef1c > > > Diff: https://reviews.apache.org/r/58973/diff/3/ > > > Testing > ------- > > > Thanks, > > Deepak Jaiswal > >
