----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60349/ -----------------------------------------------------------
Review request for hive and Ashutosh Chauhan. Bugs: HIVE-16793 https://issues.apache.org/jira/browse/HIVE-16793 Repository: hive-git Description ------- For scalar subqueries we skip adding UDF sq_count_check which have aggregates but we add it if there is a explicit group by present. We can skip it if group by is present but group by keys are constant. This patch adds a rule to do this optimization. Diffs ----- ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveRemoveSqCountCheck.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSubQueryRemoveRule.java 83d3f7436d ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 348331e052 ql/src/test/results/clientnegative/subquery_scalar_multi_rows.q.out 0a780db7ef ql/src/test/results/clientpositive/llap/subquery_scalar.q.out e94edff262 ql/src/test/results/clientpositive/llap/subquery_select.q.out 202980e975 ql/src/test/results/clientpositive/perf/query23.q.out 1fd8cb4f25 ql/src/test/results/clientpositive/perf/query44.q.out 566548089c ql/src/test/results/clientpositive/perf/query54.q.out 3cbcbe33f9 ql/src/test/results/clientpositive/perf/query58.q.out acdfc07718 ql/src/test/results/clientpositive/perf/query6.q.out 03fff79951 Diff: https://reviews.apache.org/r/60349/diff/1/ Testing ------- -Pre-commit testing - new tests Thanks, Vineet Garg