----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60950/#review180914 -----------------------------------------------------------
Thanks, couple more items. itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java Lines 471 (patched) <https://reviews.apache.org/r/60950/#comment256257> Don't think you need this sleep since you are explicitly calling HiveMetaStoreClient#close itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java Lines 500 (patched) <https://reviews.apache.org/r/60950/#comment256258> closing explicitly, so sleep should not be needed. itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java Lines 515 (patched) <https://reviews.apache.org/r/60950/#comment256262> same here. metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java Lines 298 (patched) <https://reviews.apache.org/r/60950/#comment256259> You can set this to null here. And explicitly initialize the thread local in setMetaConf. That way, you don't need to create HashMap for every thread if setMetaConf is never called (common case). metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java Lines 395 (patched) <https://reviews.apache.org/r/60950/#comment256261> null check needed if you init this to null based on feedback comment. metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java Lines 7598 (patched) <https://reviews.apache.org/r/60950/#comment256260> Once you initialize threadLocalModifiedConfig to null, check if threadLocalModifiedConfig is non null before calling notifyMetaListenersOnShutDown - Mohit Sabharwal On July 19, 2017, 7:40 a.m., PRASHANT GOLASH wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60950/ > ----------------------------------------------------------- > > (Updated July 19, 2017, 7:40 a.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > Added the code to notify meta listeners during shutdown. Shutdown would > eventually call cleanupRawStore (In both cases HMSHandler#close and > TServerEventHandler#DeleteContext), so called the notification code in that > function. > > > Diffs > ----- > > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java > fd4527e653 > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 58b9044930 > > > Diff: https://reviews.apache.org/r/60950/diff/3/ > > > Testing > ------- > > Added unit test cases for the affected codepath. > > > Thanks, > > PRASHANT GOLASH > >
