> On Aug. 16, 2017, 10:58 p.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/RelOptHiveTable.java > > Lines 304 (patched) > > <https://reviews.apache.org/r/61165/diff/2/?file=1793116#file1793116line311> > > > > Can this ever be null ?
I think it could be null for columns which have complex data type > On Aug. 16, 2017, 10:58 p.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java > > Lines 227 (patched) > > <https://reviews.apache.org/r/61165/diff/2/?file=1793118#file1793118line227> > > > > I think we shall intro a config variable here, which can be configured > > to > > a) Throw unchecked exception which is not caught above and fails query: > > mostly for testing. > > b) warning: should be default. Shall print warning about missing stats. > > Logic which is there in RelOptHiveTable. > > c) Throw checked exception: which is caught above and turns off cbo. > > This will be useful for cloud setting, where any FS interaction is slow and > > not worth slowing down compilation. Regarding c) Problem with adding this functionality is that this code is shared among logical planning and physical planning. Throwing checked exception will work for logical planning only but not physical planning and I don't think we want to throw an exception during physical planning when there is nothing to fall back on. Regarding a) I am not sure what are the scenarios where we will ever need this for testing. I am concerned about making this code more complicated by introducing too many configs/code paths. Regarding b) I agree we should have a way to warn users about missing statistics. I'll add code to show warnings about missing stats. > On Aug. 16, 2017, 10:58 p.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java > > Lines 295-296 (original), 371-374 (patched) > > <https://reviews.apache.org/r/61165/diff/2/?file=1793118#file1793118line371> > > > > Can be merged. Sorry not sure what you mean by that. Can you explain what could be merged? > On Aug. 16, 2017, 10:58 p.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java > > Lines 866 (patched) > > <https://reviews.apache.org/r/61165/diff/2/?file=1793118#file1793118line866> > > > > Same config as described above can be used here too. See above response. > On Aug. 16, 2017, 10:58 p.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java > > Lines 868 (patched) > > <https://reviews.apache.org/r/61165/diff/2/?file=1793118#file1793118line868> > > > > Also, colstate should be set to NONE in this case. ColStatistics do not keep any state, Statistics keep the state which is dervied based on if there is ColStatistics object or not. So we can't mark the state to NONE here. So we will to go through methods which call this function and set the state there. I'll update the code > On Aug. 16, 2017, 10:58 p.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java > > Lines 914 (patched) > > <https://reviews.apache.org/r/61165/diff/2/?file=1793118#file1793118line914> > > > > its an estimate anyway, may use hive.stats.max.variable.length to > > return this. The estimation is not done assuming that hive doesn't support computing column statistics for complex data type. Let me add estimation for complex data types in another patch because I don't know what are the repercussions of adding estimation for complex data types. I don't think it is trivial either and I would like to do it properly. > On Aug. 16, 2017, 10:58 p.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java > > Lines 1220 (patched) > > <https://reviews.apache.org/r/61165/diff/2/?file=1793118#file1793118line1220> > > > > Better is to traverse inside this complex type and do recursive call of > > this method. > > Or, leave a TODO and use hive.stats.max.variable.length, > > hive.stats.list.num.entries , hive.stats.map.num.entries configs to make an > > estimate. Since we just get the name of datatype it is not possible to traverse within types here. I'll see if we can add an estimate for complex data types - Vineet ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61165/#review183073 ----------------------------------------------------------- On Aug. 8, 2017, 8:10 p.m., Vineet Garg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61165/ > ----------------------------------------------------------- > > (Updated Aug. 8, 2017, 8:10 p.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Bugs: HIVE-16811 > https://issues.apache.org/jira/browse/HIVE-16811 > > > Repository: hive-git > > > Description > ------- > > This patch introduces estimation of statistics if stats doesn't already exist. > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java c16880ed2b > itests/src/test/resources/testconfiguration.properties 772113acda > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/RelOptHiveTable.java > 1d49568c8c > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java > 6cb0559ea0 > ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java 3b9ab41bed > ql/src/test/queries/clientpositive/join_reordering_no_stats.q PRE-CREATION > ql/src/test/results/clientpositive/annotate_stats_filter.q.out e22c3ef0fc > ql/src/test/results/clientpositive/annotate_stats_groupby.q.out fccfabd5d1 > ql/src/test/results/clientpositive/annotate_stats_part.q.out 866d30a8ea > ql/src/test/results/clientpositive/annotate_stats_select.q.out 67d134ba4a > ql/src/test/results/clientpositive/annotate_stats_table.q.out efc3c1f123 > ql/src/test/results/clientpositive/auto_join_reordering_values.q.out > 156be41502 > ql/src/test/results/clientpositive/auto_join_stats.q.out e80af96fcb > ql/src/test/results/clientpositive/auto_join_stats2.q.out 6ea5afa920 > ql/src/test/results/clientpositive/auto_sortmerge_join_12.q.out d129807f55 > ql/src/test/results/clientpositive/cbo_rp_annotate_stats_groupby.q.out > 23f5fcfc76 > > ql/src/test/results/clientpositive/columnStatsUpdateForStatsOptimizer_2.q.out > a7c9b3fc41 > ql/src/test/results/clientpositive/explain_rearrange.q.out 2e5f9e4626 > ql/src/test/results/clientpositive/filter_join_breaktask.q.out 8f9b6363f4 > ql/src/test/results/clientpositive/join19.q.out dd167ecabf > ql/src/test/results/clientpositive/join42.q.out 0cd31c6d66 > ql/src/test/results/clientpositive/join43.q.out 24168ca4fe > ql/src/test/results/clientpositive/join_cond_pushdown_unqual1.q.out > f77c75c232 > ql/src/test/results/clientpositive/join_cond_pushdown_unqual2.q.out > f04519f8c5 > ql/src/test/results/clientpositive/join_cond_pushdown_unqual3.q.out > f15d536945 > ql/src/test/results/clientpositive/join_cond_pushdown_unqual4.q.out > 1ec5dc415c > ql/src/test/results/clientpositive/join_hive_626.q.out 33a5fbd628 > ql/src/test/results/clientpositive/join_star.q.out 261fb53bf9 > ql/src/test/results/clientpositive/llap/acid_bucket_pruning.q.out > 97f8d6b4cc > ql/src/test/results/clientpositive/llap/auto_smb_mapjoin_14.q.out > 8bc280cedd > ql/src/test/results/clientpositive/llap/auto_sortmerge_join_1.q.out > 4b646dcba5 > ql/src/test/results/clientpositive/llap/auto_sortmerge_join_10.q.out > ab94c37fed > ql/src/test/results/clientpositive/llap/auto_sortmerge_join_11.q.out > 7e3fe4c862 > ql/src/test/results/clientpositive/llap/auto_sortmerge_join_12.q.out > 054cf1af7e > ql/src/test/results/clientpositive/llap/auto_sortmerge_join_13.q.out > 9c37848896 > ql/src/test/results/clientpositive/llap/auto_sortmerge_join_14.q.out > 21f1b3faff > ql/src/test/results/clientpositive/llap/auto_sortmerge_join_15.q.out > 03ff5a6659 > ql/src/test/results/clientpositive/llap/auto_sortmerge_join_2.q.out > 42e4cb7a5c > ql/src/test/results/clientpositive/llap/auto_sortmerge_join_3.q.out > 64c10ce953 > ql/src/test/results/clientpositive/llap/auto_sortmerge_join_4.q.out > 96854a9665 > ql/src/test/results/clientpositive/llap/auto_sortmerge_join_5.q.out > b77a879b78 > ql/src/test/results/clientpositive/llap/auto_sortmerge_join_6.q.out > 9e6053675b > ql/src/test/results/clientpositive/llap/auto_sortmerge_join_7.q.out > 13d3accf4c > ql/src/test/results/clientpositive/llap/auto_sortmerge_join_8.q.out > 7fc90fd19f > ql/src/test/results/clientpositive/llap/auto_sortmerge_join_9.q.out > 278c55b3e4 > ql/src/test/results/clientpositive/llap/bucket_groupby.q.out 5913768a6d > ql/src/test/results/clientpositive/llap/bucket_map_join_tez1.q.out > 649afb502a > ql/src/test/results/clientpositive/llap/bucket_map_join_tez2.q.out > bac4ae086c > ql/src/test/results/clientpositive/llap/bucketmapjoin1.q.out feb3bbcfc4 > ql/src/test/results/clientpositive/llap/bucketmapjoin2.q.out bda8070ba5 > ql/src/test/results/clientpositive/llap/bucketmapjoin3.q.out ae17c1b707 > ql/src/test/results/clientpositive/llap/bucketmapjoin4.q.out aab43431e6 > ql/src/test/results/clientpositive/llap/bucketmapjoin7.q.out 3a2cbb2b14 > ql/src/test/results/clientpositive/llap/bucketpruning1.q.out 922f23a29e > ql/src/test/results/clientpositive/llap/bucketsortoptimize_insert_2.q.out > e4fed1124b > ql/src/test/results/clientpositive/llap/bucketsortoptimize_insert_6.q.out > 67e925ad99 > ql/src/test/results/clientpositive/llap/bucketsortoptimize_insert_7.q.out > 8691d0d34e > > ql/src/test/results/clientpositive/llap/columnStatsUpdateForStatsOptimizer_1.q.out > 6d941fd4f2 > ql/src/test/results/clientpositive/llap/column_access_stats.q.out > c56c818617 > ql/src/test/results/clientpositive/llap/column_table_stats.q.out c7726fec30 > ql/src/test/results/clientpositive/llap/column_table_stats_orc.q.out > 6dff50f9f1 > ql/src/test/results/clientpositive/llap/constprog_dpp.q.out 8f51db31b8 > ql/src/test/results/clientpositive/llap/constprog_semijoin.q.out 4bdb186dfa > ql/src/test/results/clientpositive/llap/correlationoptimizer4.q.out > 0f8ce658e5 > ql/src/test/results/clientpositive/llap/count.q.out 0ef26e57ab > ql/src/test/results/clientpositive/llap/cross_product_check_1.q.out > 2bc17cb532 > ql/src/test/results/clientpositive/llap/cross_product_check_2.q.out > c8657881ee > ql/src/test/results/clientpositive/llap/cte_3.q.out b6cda54493 > ql/src/test/results/clientpositive/llap/cte_5.q.out 58a963b8a2 > ql/src/test/results/clientpositive/llap/cte_mat_3.q.out 31c59596f6 > ql/src/test/results/clientpositive/llap/cte_mat_4.q.out c23e9851c5 > ql/src/test/results/clientpositive/llap/cte_mat_5.q.out 6fa26157a7 > ql/src/test/results/clientpositive/llap/disable_merge_for_bucketing.q.out > 4a2294f71e > ql/src/test/results/clientpositive/llap/dynamic_partition_pruning.q.out > 3de40ce871 > ql/src/test/results/clientpositive/llap/dynamic_partition_pruning_2.q.out > e78429fc7f > ql/src/test/results/clientpositive/llap/dynamic_semijoin_reduction_2.q.out > 1da1121d6a > ql/src/test/results/clientpositive/llap/dynamic_semijoin_reduction_3.q.out > 78c907084a > > ql/src/test/results/clientpositive/llap/dynpart_sort_opt_vectorization.q.out > 453711c57c > ql/src/test/results/clientpositive/llap/dynpart_sort_optimization.q.out > 1dc9ed5a8c > ql/src/test/results/clientpositive/llap/dynpart_sort_optimization2.q.out > 90756c6776 > > ql/src/test/results/clientpositive/llap/dynpart_sort_optimization_acid.q.out > 788854aa04 > ql/src/test/results/clientpositive/llap/empty_join.q.out 19aa89f068 > ql/src/test/results/clientpositive/llap/except_distinct.q.out 7d2222bb6d > ql/src/test/results/clientpositive/llap/explainuser_1.q.out b36fe2a83f > ql/src/test/results/clientpositive/llap/explainuser_2.q.out 4f1a4a1f14 > ql/src/test/results/clientpositive/llap/filter_join_breaktask.q.out > c5cdb77afc > ql/src/test/results/clientpositive/llap/hybridgrace_hashjoin_1.q.out > b63ad36ac1 > ql/src/test/results/clientpositive/llap/insert1.q.out aa09585da8 > ql/src/test/results/clientpositive/llap/insert_into1.q.out 5caefe8e43 > ql/src/test/results/clientpositive/llap/intersect_all.q.out 1a3a035b0b > ql/src/test/results/clientpositive/llap/intersect_distinct.q.out a871ba3ef5 > ql/src/test/results/clientpositive/llap/intersect_merge.q.out 654cd64166 > ql/src/test/results/clientpositive/llap/jdbc_handler.q.out 54f5a4e8e4 > ql/src/test/results/clientpositive/llap/join46.q.out 079acddb28 > ql/src/test/results/clientpositive/llap/join_emit_interval.q.out 4dfb09bdea > ql/src/test/results/clientpositive/llap/join_is_not_distinct_from.q.out > eaf09ca056 > ql/src/test/results/clientpositive/llap/join_nullsafe.q.out 71685aa9db > ql/src/test/results/clientpositive/llap/join_reordering_no_stats.q.out > PRE-CREATION > ql/src/test/results/clientpositive/llap/lateral_view.q.out 7e4ad81324 > ql/src/test/results/clientpositive/llap/llap_nullscan.q.out 430bdaf834 > ql/src/test/results/clientpositive/llap/llap_partitioned.q.out d35501e82b > ql/src/test/results/clientpositive/llap/llap_smb.q.out f5eec29172 > ql/src/test/results/clientpositive/llap/llap_stats.q.out fda614f7b5 > ql/src/test/results/clientpositive/llap/llap_udf.q.out 7a95c8b4b7 > ql/src/test/results/clientpositive/llap/llapdecider.q.out 9411169802 > ql/src/test/results/clientpositive/llap/lvj_mapjoin.q.out c7c4c70916 > ql/src/test/results/clientpositive/llap/mapjoin3.q.out 45992144d1 > ql/src/test/results/clientpositive/llap/mapjoin46.q.out efada10a2b > ql/src/test/results/clientpositive/llap/mapjoin_decimal.q.out 38b8f92701 > ql/src/test/results/clientpositive/llap/mapjoin_emit_interval.q.out > fdbca8af8d > ql/src/test/results/clientpositive/llap/merge1.q.out 649c2f714b > ql/src/test/results/clientpositive/llap/merge2.q.out dd726894fd > ql/src/test/results/clientpositive/llap/mergejoin.q.out 9df5e42df2 > ql/src/test/results/clientpositive/llap/metadata_only_queries.q.out > 594e7e7fd6 > ql/src/test/results/clientpositive/llap/multiMapJoin1.q.out 6d756a822e > ql/src/test/results/clientpositive/llap/multiMapJoin2.q.out 8e7b456d0c > ql/src/test/results/clientpositive/llap/multi_count_distinct_null.q.out > 0f4f803369 > ql/src/test/results/clientpositive/llap/multi_insert_lateral_view.q.out > e5497d5a79 > ql/src/test/results/clientpositive/llap/optimize_nullscan.q.out ea129b44e9 > ql/src/test/results/clientpositive/llap/orc_llap_nonvector.q.out 01adcd47fa > ql/src/test/results/clientpositive/llap/orc_merge3.q.out fd79d9d05f > ql/src/test/results/clientpositive/llap/orc_merge4.q.out 6e2617b15d > ql/src/test/results/clientpositive/llap/orc_merge5.q.out 47096bba65 > ql/src/test/results/clientpositive/llap/orc_merge6.q.out 3969a9631c > ql/src/test/results/clientpositive/llap/orc_merge7.q.out d86d2dcf2c > ql/src/test/results/clientpositive/llap/orc_merge_incompat1.q.out > e5101f449d > ql/src/test/results/clientpositive/llap/orc_merge_incompat2.q.out > 6fcb45a600 > ql/src/test/results/clientpositive/llap/orc_predicate_pushdown.q.out > 8c6f97e613 > ql/src/test/results/clientpositive/llap/parquet_predicate_pushdown.q.out > aecbcfdfe4 > ql/src/test/results/clientpositive/llap/partition_shared_scan.q.out > bd3d247d48 > ql/src/test/results/clientpositive/llap/ppd_union_view.q.out 543d17630a > ql/src/test/results/clientpositive/llap/ptf_matchpath.q.out 6c60f98192 > ql/src/test/results/clientpositive/llap/rcfile_createas1.q.out 7d1f52657c > ql/src/test/results/clientpositive/llap/rcfile_merge3.q.out 11b0b48189 > ql/src/test/results/clientpositive/llap/rcfile_merge4.q.out 443014b99e > ql/src/test/results/clientpositive/llap/reduce_deduplicate.q.out d74e4c7c78 > ql/src/test/results/clientpositive/llap/reduce_deduplicate_distinct.q.out > e5b8d11c58 > ql/src/test/results/clientpositive/llap/sample10.q.out a3da78754f > ql/src/test/results/clientpositive/llap/schema_evol_orc_nonvec_part.q.out > 0ebb378d08 > > ql/src/test/results/clientpositive/llap/schema_evol_orc_nonvec_part_all_complex.q.out > 22c7745345 > > ql/src/test/results/clientpositive/llap/schema_evol_orc_nonvec_part_all_primitive.q.out > 4e94322705 > ql/src/test/results/clientpositive/llap/schema_evol_orc_nonvec_table.q.out > 103284ea03 > ql/src/test/results/clientpositive/llap/schema_evol_orc_vec_part.q.out > c6fc7b5dc6 > > ql/src/test/results/clientpositive/llap/schema_evol_orc_vec_part_all_complex.q.out > f57481dcc1 > > ql/src/test/results/clientpositive/llap/schema_evol_orc_vec_part_all_primitive.q.out > 3a5232ad2e > ql/src/test/results/clientpositive/llap/schema_evol_orc_vec_table.q.out > 2cd6005c55 > ql/src/test/results/clientpositive/llap/schema_evol_text_nonvec_part.q.out > 8daee2883f > > ql/src/test/results/clientpositive/llap/schema_evol_text_nonvec_part_all_complex.q.out > 12c7db4af8 > > ql/src/test/results/clientpositive/llap/schema_evol_text_nonvec_part_all_primitive.q.out > 757ea3a6c0 > ql/src/test/results/clientpositive/llap/schema_evol_text_nonvec_table.q.out > e0a4ffb6ef > ql/src/test/results/clientpositive/llap/schema_evol_text_vec_part.q.out > 45635eeb4c > > ql/src/test/results/clientpositive/llap/schema_evol_text_vec_part_all_complex.q.out > 5e0c8f709a > > ql/src/test/results/clientpositive/llap/schema_evol_text_vec_part_all_primitive.q.out > 17b078fb0c > ql/src/test/results/clientpositive/llap/schema_evol_text_vec_table.q.out > 2faf88a3fe > ql/src/test/results/clientpositive/llap/schema_evol_text_vecrow_part.q.out > d687506241 > > ql/src/test/results/clientpositive/llap/schema_evol_text_vecrow_part_all_complex.q.out > afaf69faf3 > > ql/src/test/results/clientpositive/llap/schema_evol_text_vecrow_part_all_primitive.q.out > 59d6797d63 > ql/src/test/results/clientpositive/llap/schema_evol_text_vecrow_table.q.out > 2fb3fe8111 > ql/src/test/results/clientpositive/llap/semijoin.q.out 57866737f3 > ql/src/test/results/clientpositive/llap/skewjoin.q.out f4fc43edfa > ql/src/test/results/clientpositive/llap/skewjoinopt15.q.out 1f667c0873 > ql/src/test/results/clientpositive/llap/smb_cache.q.out 932b21105b > ql/src/test/results/clientpositive/llap/smb_mapjoin_14.q.out 63984cc941 > ql/src/test/results/clientpositive/llap/smb_mapjoin_15.q.out df89454387 > ql/src/test/results/clientpositive/llap/smb_mapjoin_17.q.out 183c022a5d > ql/src/test/results/clientpositive/llap/smb_mapjoin_18.q.out e2d5e4e4c2 > ql/src/test/results/clientpositive/llap/smb_mapjoin_19.q.out c3b29ea2bd > ql/src/test/results/clientpositive/llap/smb_mapjoin_4.q.out fbfc902e85 > ql/src/test/results/clientpositive/llap/smb_mapjoin_5.q.out 1589329c38 > ql/src/test/results/clientpositive/llap/smb_mapjoin_6.q.out 2c1ee962bc > ql/src/test/results/clientpositive/llap/sqlmerge.q.out 562d4440ba > ql/src/test/results/clientpositive/llap/stats11.q.out 48d76cf179 > ql/src/test/results/clientpositive/llap/stats_only_null.q.out ab91ea738c > ql/src/test/results/clientpositive/llap/subquery_exists.q.out 4d223923a7 > ql/src/test/results/clientpositive/llap/subquery_in.q.out a8312896dc > ql/src/test/results/clientpositive/llap/subquery_multi.q.out 5673f0ee8c > ql/src/test/results/clientpositive/llap/subquery_notin.q.out 3c6e95ae70 > ql/src/test/results/clientpositive/llap/subquery_scalar.q.out 05d4fc8093 > ql/src/test/results/clientpositive/llap/subquery_select.q.out fd108986b9 > ql/src/test/results/clientpositive/llap/sysdb.q.out d476b3b1a7 > ql/src/test/results/clientpositive/llap/table_access_keys_stats.q.out > 85459229f5 > ql/src/test/results/clientpositive/llap/temp_table.q.out e97b3dd741 > ql/src/test/results/clientpositive/llap/tez_bmj_schema_evolution.q.out > c83da8b123 > ql/src/test/results/clientpositive/llap/tez_dml.q.out ece6946fb8 > ql/src/test/results/clientpositive/llap/tez_join.q.out 69a830d2d2 > ql/src/test/results/clientpositive/llap/tez_join_hash.q.out e313bad4dc > ql/src/test/results/clientpositive/llap/tez_join_result_complex.q.out > a7ec89529b > ql/src/test/results/clientpositive/llap/tez_nway_join.q.out 86f040234b > ql/src/test/results/clientpositive/llap/tez_self_join.q.out 8ba9761d76 > ql/src/test/results/clientpositive/llap/tez_smb_1.q.out 2fcf0fc71c > ql/src/test/results/clientpositive/llap/tez_smb_empty.q.out e4c246afec > ql/src/test/results/clientpositive/llap/tez_smb_main.q.out e5f6940e48 > ql/src/test/results/clientpositive/llap/tez_union_group_by.q.out 67cd110a61 > ql/src/test/results/clientpositive/llap/unionDistinct_1.q.out 8d97fa4fab > ql/src/test/results/clientpositive/llap/union_remove_26.q.out 9ddc2c807e > ql/src/test/results/clientpositive/llap/vector_adaptor_usage_mode.q.out > e63cbf8063 > ql/src/test/results/clientpositive/llap/vector_aggregate_9.q.out cf3dc23281 > ql/src/test/results/clientpositive/llap/vector_aggregate_without_gby.q.out > 0cf62d364c > ql/src/test/results/clientpositive/llap/vector_auto_smb_mapjoin_14.q.out > b4386c8673 > ql/src/test/results/clientpositive/llap/vector_between_columns.q.out > bcf9cd268c > ql/src/test/results/clientpositive/llap/vector_between_in.q.out 664e342990 > ql/src/test/results/clientpositive/llap/vector_binary_join_groupby.q.out > 9f059b9312 > ql/src/test/results/clientpositive/llap/vector_bround.q.out d463f1a6e7 > ql/src/test/results/clientpositive/llap/vector_bucket.q.out 6dd0cfb8b0 > ql/src/test/results/clientpositive/llap/vector_cast_constant.q.out > 2b8aaaa0df > ql/src/test/results/clientpositive/llap/vector_char_2.q.out 48c62812f0 > ql/src/test/results/clientpositive/llap/vector_char_4.q.out d164ebef3c > ql/src/test/results/clientpositive/llap/vector_char_mapjoin1.q.out > ab67adcc35 > ql/src/test/results/clientpositive/llap/vector_coalesce_2.q.out 55a1d4208a > ql/src/test/results/clientpositive/llap/vector_coalesce_3.q.out 85ddc7cc8d > ql/src/test/results/clientpositive/llap/vector_complex_all.q.out 4503cc4696 > ql/src/test/results/clientpositive/llap/vector_complex_join.q.out > e389cd36c2 > ql/src/test/results/clientpositive/llap/vector_count.q.out c1a24cceb7 > ql/src/test/results/clientpositive/llap/vector_count_distinct.q.out > d45a15ffb8 > ql/src/test/results/clientpositive/llap/vector_data_types.q.out b9bb0a20aa > ql/src/test/results/clientpositive/llap/vector_date_1.q.out d80da7ea65 > ql/src/test/results/clientpositive/llap/vector_decimal_1.q.out b3ff557bf4 > ql/src/test/results/clientpositive/llap/vector_decimal_10_0.q.out > f105c5ad2f > ql/src/test/results/clientpositive/llap/vector_decimal_2.q.out 947ac81001 > ql/src/test/results/clientpositive/llap/vector_decimal_aggregate.q.out > 8ea03f7446 > ql/src/test/results/clientpositive/llap/vector_decimal_expressions.q.out > 28478077ec > ql/src/test/results/clientpositive/llap/vector_decimal_mapjoin.q.out > c62e25a0e5 > ql/src/test/results/clientpositive/llap/vector_decimal_math_funcs.q.out > e0c680e169 > ql/src/test/results/clientpositive/llap/vector_decimal_precision.q.out > 3f32eb2822 > ql/src/test/results/clientpositive/llap/vector_decimal_round.q.out > d7a4e87396 > ql/src/test/results/clientpositive/llap/vector_decimal_round_2.q.out > a3bf091fc1 > ql/src/test/results/clientpositive/llap/vector_decimal_udf.q.out 56127a51f4 > ql/src/test/results/clientpositive/llap/vector_decimal_udf2.q.out > e00de78470 > ql/src/test/results/clientpositive/llap/vector_distinct_2.q.out b7f6a80686 > ql/src/test/results/clientpositive/llap/vector_groupby4.q.out 43995549f6 > ql/src/test/results/clientpositive/llap/vector_groupby6.q.out a91b715780 > ql/src/test/results/clientpositive/llap/vector_groupby_3.q.out cd9ff27350 > ql/src/test/results/clientpositive/llap/vector_groupby_cube1.q.out > ced38dc564 > ql/src/test/results/clientpositive/llap/vector_groupby_grouping_id1.q.out > aabe7d6933 > ql/src/test/results/clientpositive/llap/vector_groupby_grouping_id2.q.out > d16044c0e9 > ql/src/test/results/clientpositive/llap/vector_groupby_grouping_id3.q.out > 22a71e4eeb > ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets1.q.out > 5d3434792f > ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets2.q.out > 4deef94c54 > ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets3.q.out > 95964155ad > ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets4.q.out > 4f914c8525 > ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets5.q.out > c9b666c2de > ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets6.q.out > 4081ea966b > > ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets_grouping.q.out > fccb6d6f54 > > ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets_limit.q.out > 18e032a398 > > ql/src/test/results/clientpositive/llap/vector_groupby_grouping_window.q.out > 5d0b23c7c7 > ql/src/test/results/clientpositive/llap/vector_groupby_reduce.q.out > 56afa70575 > ql/src/test/results/clientpositive/llap/vector_groupby_rollup1.q.out > d1002e486b > ql/src/test/results/clientpositive/llap/vector_grouping_sets.q.out > a84da2ccd8 > ql/src/test/results/clientpositive/llap/vector_include_no_sel.q.out > f5cbe53836 > ql/src/test/results/clientpositive/llap/vector_inner_join.q.out 3e2ed6f1b5 > ql/src/test/results/clientpositive/llap/vector_interval_1.q.out bc3486fd9a > ql/src/test/results/clientpositive/llap/vector_interval_2.q.out 1509926360 > ql/src/test/results/clientpositive/llap/vector_interval_arithmetic.q.out > 2d4db5ecfa > ql/src/test/results/clientpositive/llap/vector_interval_mapjoin.q.out > 0024fea77a > ql/src/test/results/clientpositive/llap/vector_join30.q.out 6b5e604b33 > ql/src/test/results/clientpositive/llap/vector_left_outer_join2.q.out > 8912bd47a4 > ql/src/test/results/clientpositive/llap/vector_leftsemi_mapjoin.q.out > c02f879d02 > ql/src/test/results/clientpositive/llap/vector_mr_diff_schema_alias.q.out > 03c6d3fe54 > ql/src/test/results/clientpositive/llap/vector_multi_insert.q.out > d537297c85 > ql/src/test/results/clientpositive/llap/vector_nullsafe_join.q.out > 6225986136 > > ql/src/test/results/clientpositive/llap/vector_number_compare_projection.q.out > a172fd2b15 > ql/src/test/results/clientpositive/llap/vector_orderby_5.q.out a99cb2b412 > ql/src/test/results/clientpositive/llap/vector_outer_join0.q.out 5017c00239 > > ql/src/test/results/clientpositive/llap/vector_partition_diff_num_cols.q.out > 4683b4bb62 > ql/src/test/results/clientpositive/llap/vector_partitioned_date_time.q.out > c5f7128d9d > ql/src/test/results/clientpositive/llap/vector_ptf_part_simple.q.out > 805d5a23ef > ql/src/test/results/clientpositive/llap/vector_reduce1.q.out 4a4e710854 > ql/src/test/results/clientpositive/llap/vector_reduce2.q.out d937146489 > ql/src/test/results/clientpositive/llap/vector_reduce3.q.out 382841f7d3 > ql/src/test/results/clientpositive/llap/vector_reduce_groupby_decimal.q.out > 579bb61d38 > ql/src/test/results/clientpositive/llap/vector_string_concat.q.out > d5331ec830 > ql/src/test/results/clientpositive/llap/vector_struct_in.q.out d583f09cb1 > ql/src/test/results/clientpositive/llap/vector_udf1.q.out b8d19c5637 > ql/src/test/results/clientpositive/llap/vector_udf_character_length.q.out > 559a82b1a4 > ql/src/test/results/clientpositive/llap/vector_udf_octet_length.q.out > cee832212e > ql/src/test/results/clientpositive/llap/vector_varchar_4.q.out 5979f8be7f > ql/src/test/results/clientpositive/llap/vector_varchar_mapjoin1.q.out > c96b9dff68 > ql/src/test/results/clientpositive/llap/vector_varchar_simple.q.out > 4e48a27e71 > ql/src/test/results/clientpositive/llap/vector_when_case_null.q.out > f137c63aa0 > ql/src/test/results/clientpositive/llap/vector_windowing_navfn.q.out > 6d66a55d8a > ql/src/test/results/clientpositive/llap/vectorization_decimal_date.q.out > 74455f5a52 > ql/src/test/results/clientpositive/llap/vectorization_part_project.q.out > 85c4dd0f63 > ql/src/test/results/clientpositive/llap/vectorization_short_regress.q.out > 38598b489a > ql/src/test/results/clientpositive/llap/vectorized_bucketmapjoin1.q.out > 0ba948174c > ql/src/test/results/clientpositive/llap/vectorized_context.q.out 855a50f91c > ql/src/test/results/clientpositive/llap/vectorized_date_funcs.q.out > 39e8096bed > ql/src/test/results/clientpositive/llap/vectorized_distinct_gby.q.out > fe9f0d22f6 > > ql/src/test/results/clientpositive/llap/vectorized_dynamic_partition_pruning.q.out > 690cab80d2 > > ql/src/test/results/clientpositive/llap/vectorized_dynamic_semijoin_reduction.q.out > 0af7204256 > ql/src/test/results/clientpositive/llap/vectorized_join46.q.out c31934bd07 > ql/src/test/results/clientpositive/llap/vectorized_parquet.q.out e904286cb4 > ql/src/test/results/clientpositive/llap/vectorized_parquet_types.q.out > cdf6b3d225 > ql/src/test/results/clientpositive/llap/vectorized_ptf.q.out cf5bdea294 > ql/src/test/results/clientpositive/llap/vectorized_timestamp.q.out > 24f8d36912 > ql/src/test/results/clientpositive/llap/vectorized_timestamp_funcs.q.out > f6dcb7cc54 > ql/src/test/results/clientpositive/merge_join_1.q.out 4d2c4cf0f4 > ql/src/test/results/clientpositive/mergejoin.q.out 1961d83c68 > ql/src/test/results/clientpositive/mergejoins_mixed.q.out e1125e9cb8 > ql/src/test/results/clientpositive/perf/query14.q.out 74c7660398 > ql/src/test/results/clientpositive/perf/query23.q.out ebd2271108 > ql/src/test/results/clientpositive/ppd_join5.q.out 551769c73a > ql/src/test/results/clientpositive/ppd_outer_join5.q.out 75b73800ed > ql/src/test/results/clientpositive/ppd_repeated_alias.q.out 738424bb5b > ql/src/test/results/clientpositive/smb_mapjoin_47.q.out 34ed7b87c4 > ql/src/test/results/clientpositive/spark/auto_join_reordering_values.q.out > 29b4419e94 > ql/src/test/results/clientpositive/spark/auto_join_stats.q.out db98adc55a > ql/src/test/results/clientpositive/spark/auto_join_stats2.q.out 9064cbc4e0 > ql/src/test/results/clientpositive/spark/auto_smb_mapjoin_14.q.out > 7a2422f528 > ql/src/test/results/clientpositive/spark/auto_sortmerge_join_12.q.out > d76360de6c > ql/src/test/results/clientpositive/spark/auto_sortmerge_join_6.q.out > de08021150 > ql/src/test/results/clientpositive/spark/auto_sortmerge_join_9.q.out > 8a302b6d0e > ql/src/test/results/clientpositive/spark/bucket_map_join_tez1.q.out > 08d115d105 > ql/src/test/results/clientpositive/spark/bucket_map_join_tez2.q.out > 4837ebfaa1 > ql/src/test/results/clientpositive/spark/column_access_stats.q.out > b1c494cba7 > ql/src/test/results/clientpositive/spark/filter_join_breaktask.q.out > 718346f83a > ql/src/test/results/clientpositive/spark/join19.q.out 35d9942cb0 > ql/src/test/results/clientpositive/spark/join_cond_pushdown_unqual1.q.out > 40695ef998 > ql/src/test/results/clientpositive/spark/join_cond_pushdown_unqual2.q.out > df23dbf548 > ql/src/test/results/clientpositive/spark/join_cond_pushdown_unqual3.q.out > 248512a3db > ql/src/test/results/clientpositive/spark/join_cond_pushdown_unqual4.q.out > cc8d633f2d > ql/src/test/results/clientpositive/spark/join_hive_626.q.out f304bb9d35 > ql/src/test/results/clientpositive/spark/join_star.q.out 5d747ec73d > ql/src/test/results/clientpositive/spark/mergejoins_mixed.q.out 9306718274 > ql/src/test/results/clientpositive/spark/ppd_join5.q.out 2b05a1c917 > ql/src/test/results/clientpositive/spark/ppd_outer_join5.q.out 0813d6fcb5 > > ql/src/test/results/clientpositive/spark/spark_dynamic_partition_pruning.q.out > d9da7627b3 > > ql/src/test/results/clientpositive/spark/spark_dynamic_partition_pruning_mapjoin_only.q.out > 564a6a24ba > ql/src/test/results/clientpositive/spark/spark_explainuser_1.q.out > bf0708b432 > ql/src/test/results/clientpositive/spark/spark_use_op_stats.q.out > b277ddc4b4 > ql/src/test/results/clientpositive/spark/stats_only_null.q.out 94f955c82d > ql/src/test/results/clientpositive/spark/table_access_keys_stats.q.out > 9291c01867 > ql/src/test/results/clientpositive/stats_only_null.q.out de1b017989 > ql/src/test/results/clientpositive/stats_partial_size.q.out c779741314 > ql/src/test/results/clientpositive/stats_ppr_all.q.out d4060c600b > ql/src/test/results/clientpositive/tez/explainanalyze_2.q.out c86717790d > ql/src/test/results/clientpositive/tez/explainanalyze_3.q.out 9d47066297 > ql/src/test/results/clientpositive/tez/explainanalyze_5.q.out 1764164a91 > ql/src/test/results/clientpositive/tez/explainuser_3.q.out f70d711fc4 > ql/src/test/results/clientpositive/tez/hybridgrace_hashjoin_1.q.out > 8ee4f4d716 > ql/src/test/results/clientpositive/tez/multi_count_distinct.q.out > 82c09faa5c > ql/src/test/results/clientpositive/tez/tez-tag.q.out 1201ee4954 > ql/src/test/results/clientpositive/tez/vector_join_part_col_char.q.out > 2b9882e390 > ql/src/test/results/clientpositive/tez/vector_non_string_partition.q.out > e09cbb91e5 > ql/src/test/results/clientpositive/vector_mr_diff_schema_alias.q.out > a659b9e869 > ql/src/test/results/clientpositive/vector_outer_join6.q.out 75d3fcb240 > ql/src/test/results/clientpositive/vectorized_context.q.out dac9b6b143 > > > Diff: https://reviews.apache.org/r/61165/diff/2/ > > > Testing > ------- > > * Updated existing tests > * Added new test > > > Thanks, > > Vineet Garg > >
