> On Aug. 24, 2017, 3:03 p.m., Ashutosh Chauhan wrote: > > ql/src/test/queries/clientpositive/localtimezone.q > > Lines 27 (patched) > > <https://reviews.apache.org/r/61188/diff/2/?file=1802566#file1802566line27> > > > > Shouldn't tpye be now : timestamp with *local* time zone?
Yes, I forgot to change the q file in the patch and test failed :) I will update it. > On Aug. 24, 2017, 3:03 p.m., Ashutosh Chauhan wrote: > > ql/src/test/queries/clientpositive/localtimezone.q > > Lines 78 (patched) > > <https://reviews.apache.org/r/61188/diff/2/?file=1802566#file1802566line78> > > > > We shall throw exception for this since we only allow local time zone. Same as above. - Jesús ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61188/#review183739 ----------------------------------------------------------- On Aug. 23, 2017, 9:02 p.m., Jesús Camacho Rodríguez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61188/ > ----------------------------------------------------------- > > (Updated Aug. 23, 2017, 9:02 p.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Bugs: HIVE-16614 > https://issues.apache.org/jira/browse/HIVE-16614 > > > Repository: hive-git > > > Description > ------- > > HIVE-16614 (timestamp with local time zone) > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/common/type/TimestampTZ.java > ed83871a4a049a3e1a8417fb68bd1a1e66026a4e > common/src/java/org/apache/hadoop/hive/common/type/TimestampTZUtil.java > PRE-CREATION > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > 2fb004c0ecea6d371a3a18e4d0eab19e5b80af55 > common/src/test/org/apache/hadoop/hive/common/type/TestTimestampTZ.java > 0cef77a9cee263b98495c4d139d978364d9320b0 > jdbc/src/java/org/apache/hive/jdbc/HiveBaseResultSet.java > 6742423ff509c8098ad821540ff778a0db2dd6a7 > jdbc/src/java/org/apache/hive/jdbc/JdbcColumn.java > bf42f0d76e385e4cbe633970451f1a5d60a3493e > ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java > 9795f3ef9874a345736ac700ff213822a25c8c69 > ql/src/java/org/apache/hadoop/hive/ql/exec/GroupByOperator.java > 9c5e7e27a5c4327cf841a468aa7bdbc9456b2f98 > ql/src/java/org/apache/hadoop/hive/ql/exec/SerializationUtilities.java > 8902f6c2db72d9804f34b9006d867d85d54ee916 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConstantPropagateProcFactory.java > 517ce312a7783d32b1a9fe91f22ac2293279c112 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveType.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ExprNodeConverter.java > f974cc9195772e09b5d09b4da6adf2919ceb529f > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/RexNodeConverter.java > 7665f56cfccf6c92e0fb7d03e475a4db6822f9e0 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/SqlFunctionConverter.java > a9198a1c7082662d6ac446d8ce9edd7aebde77db > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/TypeConverter.java > 2df7588cba01399ae980059a7b2f447a9973f2e6 > ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java > a0e51713694a66226e04b75370b12aecf06fda45 > ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g > da52cd571247919c5efb41590f207de9c2a0ef1d > ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g > 1386e65885e614875509bbadf4590419cdcd57b6 > ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java > 632b9c62cfeb34e9e1cad17ad5f522fe06b882b0 > ql/src/java/org/apache/hadoop/hive/ql/processors/SetProcessor.java > 1458211b81514963975269ea0dcd33276d851c28 > ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java > eb02a919538bccfa67d102bca1c12b76cfe44aa0 > ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToBoolean.java > 1605877f224fcb3a91b6bd772a86aff54d481e9d > ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToString.java > c10552ad9d357f06739f330cd296b8441ec63e87 > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDF.java > 0898de6c295bbc5b10d608e83f63d314a7353829 > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDate.java > 4247afd25f3616438f6155a52bc55db0b0617b49 > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToTimestampTZ.java > e96012bbf2babc3b9f200a61862540fbf5ded999 > ql/src/test/queries/clientpositive/localtimezone.q PRE-CREATION > ql/src/test/queries/clientpositive/timestamptz_2.q > a335f529d7bff9e2495ff10fd38d30e2d77bb909 > ql/src/test/results/clientpositive/annotate_stats_select.q.out > 67d134ba4a9cd8db12513d7de8bb9d03b52a4f3d > ql/src/test/results/clientpositive/constantfolding.q.out > 10e185f00b8a8f848122e604906a72dd54ee9d3d > ql/src/test/results/clientpositive/localtimezone.q.out PRE-CREATION > ql/src/test/results/clientpositive/timestamptz.q.out > 626fe92286651560a7fb0d6dca98584d49fb671f > ql/src/test/results/clientpositive/timestamptz_1.q.out > 75bbfac3e816e3979a72726b696e88e98d7d1e73 > ql/src/test/results/clientpositive/timestamptz_2.q.out > 2666735fbc4660723598c6ef70e5913185118328 > serde/if/serde.thrift c331242a5361f02aa546c35e97c8000ec3760672 > serde/src/gen/thrift/gen-cpp/serde_constants.h > e261ed39905ed9f74fe020f76e018bb1eaa24c03 > serde/src/gen/thrift/gen-cpp/serde_constants.cpp > 5674b5ed348e5a023c668ca91337749090eeb69b > > serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/serdeConstants.java > 4da1d3b3392c965fc116c37261bf22785d867ab5 > serde/src/gen/thrift/gen-php/org/apache/hadoop/hive/serde/Types.php > 1a2e8d75ce2c73f181bc60cb5219aa9fff5aad07 > serde/src/gen/thrift/gen-py/org_apache_hadoop_hive_serde/constants.py > 79ff5256f4de42ec14d2bd146cf0f7c11bde4637 > serde/src/gen/thrift/gen-rb/serde_constants.rb > 28103242c3f65ab55490799f224390594b572509 > serde/src/java/org/apache/hadoop/hive/serde2/SerDeUtils.java > b9d23dd72580a684788747bfdff4c35b08726fba > > serde/src/java/org/apache/hadoop/hive/serde2/binarysortable/BinarySortableSerDe.java > f333ae9938b5f17925c1e37024e7d3b85037a990 > serde/src/java/org/apache/hadoop/hive/serde2/io/TimestampTZWritable.java > 8c3f8f647152c4447ef0ee5255d6b8b4727406d0 > serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyFactory.java > f87ac762286ddaa98e2a96a739d75caa117dc8f3 > serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazySerDeParameters.java > ee4bb345cee4d0bf6f7952c5e8549ee51059a0ec > serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyTimestampTZ.java > df5c586f56274f722f8779afb4bb6262b61d5f02 > serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyUtils.java > c811753015c9f071406214f002eca17ce3499cdd > > serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyPrimitiveObjectInspectorFactory.java > 6d1ee1e97bb02a53774d272a22b493fa65136800 > > serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyTimestampTZObjectInspector.java > 7336385a7aea4187d729694437fb32b6f88229a5 > > serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryFactory.java > 16609bb48e33222defa25570bddba8c4386d06d7 > > serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinarySerDe.java > 268f37497d1894e9a498b2044c71733636ff932d > > serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryTimestampTZ.java > 6d9ca6e93781f9aafca91be203bed7c4c078e76a > > serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryUtils.java > 4c6725981914bda354e2a1df386e5837910ec29b > > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorConverters.java > 7025ebfc208c05a4a6e948bc73b7af79ec338928 > > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java > 0d6fd4afd7bd326a19501c85bdc7e13648b121f1 > > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/PrimitiveObjectInspector.java > f95dd375b308c60ed5019563baeff3bff416892e > > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/JavaTimestampLocalTZObjectInspector.java > PRE-CREATION > > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/JavaTimestampTZObjectInspector.java > 32b9c69909488dc4e32cf4ba84d7b97881c4d926 > > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorConverter.java > d4b7a32bcaebb4b8402286b970a3fe388f31474a > > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorFactory.java > 2425c30f012fd536245f6e333891decd0abf98c6 > > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorUtils.java > 886c29885241ecf55532e030120e23f9fc19145c > > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/SettableTimestampTZObjectInspector.java > 032bc38a474cd3cf722cd8e34e9b9bd71b180079 > > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/TimestampTZObjectInspector.java > d142d38860dcc28050b21099e78c12fa225e83e7 > > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantTimestampTZObjectInspector.java > 5805ce8b5e1512d43463017a4fba5be3fa496820 > > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableTimestampLocalTZObjectInspector.java > PRE-CREATION > > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableTimestampTZObjectInspector.java > 0b622c1ed5a268979ff2e04fc9e1d3ce0e1d78f9 > serde/src/java/org/apache/hadoop/hive/serde2/thrift/Type.java > 809f45b7ae129f37e4c3f254a0d4235d0d18f895 > > serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TimestampLocalTZTypeInfo.java > PRE-CREATION > serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoFactory.java > b0e0bf28be82eec23ad285e8f8f785d6f503fb60 > serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java > 8be689653229b01d95f3610bc2c023ff65916e79 > > serde/src/test/org/apache/hadoop/hive/serde2/io/TestTimestampTZWritable.java > 73b81b9cb578fd391bde318a957763ec31aecfcf > > > Diff: https://reviews.apache.org/r/61188/diff/2/ > > > Testing > ------- > > > Thanks, > > Jesús Camacho Rodríguez > >
