-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63458/#review189871
-----------------------------------------------------------




common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
Lines 2477 (patched)
<https://reviews.apache.org/r/63458/#comment267100>

    nit: missing space between words



common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
Lines 2479 (patched)
<https://reviews.apache.org/r/63458/#comment267101>

    nit: missing space between words



service/src/java/org/apache/hive/service/cli/session/SessionManager.java
Lines 472 (patched)
<https://reviews.apache.org/r/63458/#comment267103>

    Right, you may actually use a combination of concurrent hashmap with atomics



service/src/java/org/apache/hive/service/cli/session/SessionManager.java
Lines 477 (patched)
<https://reviews.apache.org/r/63458/#comment267106>

    This potentially leak IP addresses of clients in the log file - would be 
better to avoid it.



service/src/java/org/apache/hive/service/cli/session/SessionManager.java
Lines 497 (patched)
<https://reviews.apache.org/r/63458/#comment267107>

    why is this <= 0 rather then == 0?



service/src/java/org/apache/hive/service/cli/session/SessionManager.java
Lines 503 (patched)
<https://reviews.apache.org/r/63458/#comment267108>

    This is leaking IP addresses in the log file


- Alexander Kolbasov


On Nov. 1, 2017, 2:04 a.m., Prasanth_J wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63458/
> -----------------------------------------------------------
> 
> (Updated Nov. 1, 2017, 2:04 a.m.)
> 
> 
> Review request for hive, Sergey Shelukhin and Thejas Nair.
> 
> 
> Bugs: HIVE-16917
>     https://issues.apache.org/jira/browse/HIVE-16917
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-16917: HiveServer2 guard rails - Limit concurrent connections from user
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 
> a3c853a5c5a2a3e72ae0141d0ad836ec95516280 
>   service/src/java/org/apache/hive/service/cli/session/SessionManager.java 
> 9b2ae57ee498e9b712cc87b16ba223995519611c 
>   service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 
> 6354c8c5450eaa8ab91dd59387f2eddf0eb84389 
>   
> service/src/test/org/apache/hive/service/cli/TestCLIServiceConnectionLimits.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63458/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Prasanth_J
> 
>

Reply via email to